Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape PKG_CHECK_MODULES #1540

Merged
merged 2 commits into from
Aug 17, 2021
Merged

Escape PKG_CHECK_MODULES #1540

merged 2 commits into from
Aug 17, 2021

Conversation

catap
Copy link
Contributor

@catap catap commented Aug 14, 2021

This small changes allows to fix an issues avast/retdec#990 and probably #1171

The root cause of this issues is different shell which is used. Some simple shell like dsh I belive can't survive on this line without escaping, some modern like bash easly can.

Thus at § 3.5 at https://autotools.io/pkgconfig/pkg_check_modules.html it is cleare suggested to escape by [...].

This small changes allows to fix an issues avast/retdec#990 and probably VirusTotal#1171

The root cause of this issues is different shell which is used. Some simple shell like dsh I belive can't survive on this line without escaping, some modern like bash easly can.

Thus at § 3.5 at https://autotools.io/pkgconfig/pkg_check_modules.html it is cleare suggested to escape by `[...]`.
@google-cla
Copy link

google-cla bot commented Aug 14, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@catap
Copy link
Contributor Author

catap commented Aug 14, 2021

@googlebot I signed it!

catap added a commit to catap/retdec that referenced this pull request Aug 15, 2021
This PR is simple backports VirusTotal/yara#1540
to existed way apply patches to yara.
catap added a commit to catap/retdec that referenced this pull request Aug 15, 2021
This PR is simple backports VirusTotal/yara#1540
to existed way apply patches to yara which is fixed avast#990
catap added a commit to catap/retdec that referenced this pull request Aug 15, 2021
This PR is simple backports VirusTotal/yara#1540
to existed way apply patches to yara which is fixed avast#990
@plusvic plusvic merged commit a2f7f45 into VirusTotal:master Aug 17, 2021
@catap catap deleted the patch-1 branch August 19, 2021 17:09
xkubov pushed a commit to avast/retdec that referenced this pull request Aug 26, 2021
This PR is simple backports VirusTotal/yara#1540
to existed way apply patches to yara which is fixed #990
xkubov pushed a commit to avast/retdec that referenced this pull request Aug 26, 2021
This PR is simple backports VirusTotal/yara#1540
to existed way apply patches to yara which is fixed #990
tarterp pushed a commit to mandiant/yara that referenced this pull request Mar 31, 2022
* Escape `PKG_CHECK_MODULES`

This small changes allows to fix an issues avast/retdec#990 and probably VirusTotal#1171

The root cause of this issues is different shell which is used. Some simple shell like dsh I belive can't survive on this line without escaping, some modern like bash easly can.

Thus at § 3.5 at https://autotools.io/pkgconfig/pkg_check_modules.html it is cleare suggested to escape by `[...]`.

* Escape `protobuf-c`
maximelb pushed a commit to refractionPOINT/yara that referenced this pull request Nov 17, 2022
* Escape `PKG_CHECK_MODULES`

This small changes allows to fix an issues avast/retdec#990 and probably VirusTotal#1171

The root cause of this issues is different shell which is used. Some simple shell like dsh I belive can't survive on this line without escaping, some modern like bash easly can.

Thus at § 3.5 at https://autotools.io/pkgconfig/pkg_check_modules.html it is cleare suggested to escape by `[...]`.

* Escape `protobuf-c`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants