-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escape PKG_CHECK_MODULES
#1540
Escape PKG_CHECK_MODULES
#1540
Conversation
This small changes allows to fix an issues avast/retdec#990 and probably VirusTotal#1171 The root cause of this issues is different shell which is used. Some simple shell like dsh I belive can't survive on this line without escaping, some modern like bash easly can. Thus at § 3.5 at https://autotools.io/pkgconfig/pkg_check_modules.html it is cleare suggested to escape by `[...]`.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
This PR is simple backports VirusTotal/yara#1540 to existed way apply patches to yara.
This PR is simple backports VirusTotal/yara#1540 to existed way apply patches to yara which is fixed avast#990
This PR is simple backports VirusTotal/yara#1540 to existed way apply patches to yara which is fixed avast#990
This PR is simple backports VirusTotal/yara#1540 to existed way apply patches to yara which is fixed #990
This PR is simple backports VirusTotal/yara#1540 to existed way apply patches to yara which is fixed #990
* Escape `PKG_CHECK_MODULES` This small changes allows to fix an issues avast/retdec#990 and probably VirusTotal#1171 The root cause of this issues is different shell which is used. Some simple shell like dsh I belive can't survive on this line without escaping, some modern like bash easly can. Thus at § 3.5 at https://autotools.io/pkgconfig/pkg_check_modules.html it is cleare suggested to escape by `[...]`. * Escape `protobuf-c`
* Escape `PKG_CHECK_MODULES` This small changes allows to fix an issues avast/retdec#990 and probably VirusTotal#1171 The root cause of this issues is different shell which is used. Some simple shell like dsh I belive can't survive on this line without escaping, some modern like bash easly can. Thus at § 3.5 at https://autotools.io/pkgconfig/pkg_check_modules.html it is cleare suggested to escape by `[...]`. * Escape `protobuf-c`
This small changes allows to fix an issues avast/retdec#990 and probably #1171
The root cause of this issues is different shell which is used. Some simple shell like dsh I belive can't survive on this line without escaping, some modern like bash easly can.
Thus at § 3.5 at https://autotools.io/pkgconfig/pkg_check_modules.html it is cleare suggested to escape by
[...]
.