Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing type for BrowserOnly children #5475

Merged
merged 4 commits into from
May 9, 2022
Merged

Fixing type for BrowserOnly children #5475

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9d077d5
Change children type to ReactElement<any, any> in BrowserOnly from Br…
YannBirba May 9, 2022
0cf5ebd
Update index.ts
YannBirba May 9, 2022
fbaff3b
Merge branch 'main' into fix-types-declaration-browserUtils
dac09 May 9, 2022
a893b52
Also change return type of browserOnly
dac09 May 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/prerender/src/browserUtils/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import type { ReactElement } from 'react'
import { useMemo } from 'react'

/* Web side prerender utils, to be used on the browser */
Expand All @@ -14,8 +15,8 @@ export const useIsBrowser = () => {
}, [])
}

export const BrowserOnly = ({ children }: { children: React.ReactNode }) => {
export const BrowserOnly = ({ children }: { children: ReactElement }) => {
const isBrowser = useIsBrowser()

return isBrowser && children
return isBrowser ? children : null
}