Fixing type for BrowserOnly children #5475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for redwoodjs-docs canceled.
|
|
Thanks for the PR @YannBirba - this does look like an issue, definitely - but I wonder if we can just use ReactElement without the any in the generics? |
|
Yeah it's my bad, i deleted <any , any> and it works as well. |
dac09
approved these changes
May 9, 2022
There was a problem hiding this comment.
Thanks @YannBirba - also made a small change as I saw a new TS error - probably didn't happen when I first wrote this. Please do confirm if its all ok for you now? Seems fine from my quick check
|
It's good for me |
|
Thank you for your contribution! 🚀🚀🚀 Happy Redwood-ing! |
dac09
added a commit
to dac09/redwood
that referenced
this pull request
May 10, 2022
…ctmode-gen * 'main' of github.com:redwoodjs/redwood: Update yarn.lock fix(deps): update graphql-tools monorepo (redwoodjs#5487) v1.3.2 Update yarn.lock fix: Run dedupe during upgrade on yarn 3 (redwoodjs#5458) Fix/ts resolvers type (redwoodjs#5437) fix(deps): update dependency graphql to v16.5.0 (redwoodjs#5488) fixed typo of roll to role (redwoodjs#5484) fix(deps): update typescript-eslint monorepo to v5.23.0 (redwoodjs#5489) chore(deps): update dependency cypress to v9.6.1 (redwoodjs#5482) chore(deps): update dependency firebase to v9.8.1 (redwoodjs#5485) fix(deps): update dependency @types/aws-lambda to v8.10.97 (redwoodjs#5486) chore(deps): update dependency @nhost/nhost-js to v1.1.10 (redwoodjs#5479) chore(deps): update dependency @nhost/hasura-auth-js to v1.1.5 (redwoodjs#5478) Fixing type for BrowserOnly children (redwoodjs#5475) fix: Run dedupe during upgrade on yarn 3 (redwoodjs#5458) Fix/ts resolvers type (redwoodjs#5437)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed children type to ReactElement<any, any> in BrowserOnly from BrowserUtils.
During implementation of prerender in my app, i tried to use BrowserOnly to test prerender, unfortunatly children type was set to React.Node and it doesn't worked for me.
I changed it by ReactElement<any, any>.