Fix WebAuthn when event body is base64 encoded (like when deploying to Vercel) #6757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great! Thank you for the amazingly quick turnaround time on this! :) |
|
Sweet! I’ll add a test to verify that it works as expected with the encoded body. |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 3, 2022
…o Vercel) (#6757) * Use existing this.params instead of parsing this.event.body again * Adds test covering base64 encoded body for WebAuthn requests
jtoar
pushed a commit
that referenced
this pull request
Nov 3, 2022
…o Vercel) (#6757) * Use existing this.params instead of parsing this.event.body again * Adds test covering base64 encoded body for WebAuthn requests
dac09
added a commit
that referenced
this pull request
Nov 7, 2022
…aching * 'main' of github.com:redwoodjs/redwood: (21 commits) [Tutorial]: Fix Typescript code blocks inconsistency (#6801) chore: update all contributors Custom auth: Fix comment in template (#6804) fix(deps): update dependency eslint to v8.26.0 (#6785) [CRWA]: Switch to using enquirer, add engine compatibility override option (#6723) (docs): Minor Command update about Storybook (#6722) docs: Add mocking useLocation to docs (#6791) Update generated render.yaml (#6771) fix flightcontrol config template (#6789) fix: publish canary using premajor (#6794) Strip resetToken and resetTokenExpiresAt from dbAuth forgotPassword handler (#6778) Fix WebAuthn when event body is base64 encoded (like when deploying to Vercel) (#6757) fix(deps): update jest monorepo (#6787) fix(deps): update dependency react-hook-form to v7.39.1 (#6786) fix(deps): update dependency fastify to v4.9.2 (#6781) fix(deps): update dependency @apollo/client to v3.7.1 (#6780) chore: fix and rebuild test project fixture (#6775) fix: add prisma resolutions to tutorial e2e test proj (#6772) fix(deps): update prisma monorepo to v4.5.0 (#6485) Fix dbauth webauthn template (redundant type import) (#6769) ...
jtoar
pushed a commit
that referenced
this pull request
Nov 8, 2022
…o Vercel) (#6757) * Use existing this.params instead of parsing this.event.body again * Adds test covering base64 encoded body for WebAuthn requests
|
@arimendelow this is now out in v3.3.1 |
jtoar
pushed a commit
that referenced
this pull request
Nov 8, 2022
…o Vercel) (#6757) * Use existing this.params instead of parsing this.event.body again * Adds test covering base64 encoded body for WebAuthn requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this could be a 3.2.2 that'd be awesome. Otherwise can wait for 3.3.0.
Closes #6756