(docs): Minor Command update about Storybook #6722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[pull] main from redwoodjs:main
jtoar
reviewed
Oct 24, 2022
Contributor
jtoar
left a comment
jtoar
left a comment
There was a problem hiding this comment.
Thanks for getting this rolling @jacebenson! I think we could get away with even less by moving this note to the table below by adding something like "[default: true]" to the end of the flag's description, and that you can pass --no-open to disable it. That sound ok?
jtoar
approved these changes
Nov 4, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Nov 4, 2022
* Update text about how storybook opens by default and how that can be avoided * fix: implement suggestion and format Co-authored-by: Dominic Saadi <[email protected]>
jtoar
added a commit
that referenced
this pull request
Nov 4, 2022
* Update text about how storybook opens by default and how that can be avoided * fix: implement suggestion and format Co-authored-by: Dominic Saadi <[email protected]>
dac09
added a commit
that referenced
this pull request
Nov 7, 2022
…aching * 'main' of github.com:redwoodjs/redwood: (21 commits) [Tutorial]: Fix Typescript code blocks inconsistency (#6801) chore: update all contributors Custom auth: Fix comment in template (#6804) fix(deps): update dependency eslint to v8.26.0 (#6785) [CRWA]: Switch to using enquirer, add engine compatibility override option (#6723) (docs): Minor Command update about Storybook (#6722) docs: Add mocking useLocation to docs (#6791) Update generated render.yaml (#6771) fix flightcontrol config template (#6789) fix: publish canary using premajor (#6794) Strip resetToken and resetTokenExpiresAt from dbAuth forgotPassword handler (#6778) Fix WebAuthn when event body is base64 encoded (like when deploying to Vercel) (#6757) fix(deps): update jest monorepo (#6787) fix(deps): update dependency react-hook-form to v7.39.1 (#6786) fix(deps): update dependency fastify to v4.9.2 (#6781) fix(deps): update dependency @apollo/client to v3.7.1 (#6780) chore: fix and rebuild test project fixture (#6775) fix: add prisma resolutions to tutorial e2e test proj (#6772) fix(deps): update prisma monorepo to v4.5.0 (#6485) Fix dbauth webauthn template (redundant type import) (#6769) ...
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6062 mentioned that storybook opens by default when running
yarn rw storybookand that can be stopped by passing the argument--no-open.I've added some text to say that this command actually opens the browser and you can pass that
--no-opento stop it.