-
Notifications
You must be signed in to change notification settings - Fork 1k
Copy of #6173 (smoke tests + replay) #6361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
0440f2c
update playwright
jasonLaster d8045c1
downgrade playwright
jasonLaster 64d5e32
disable matrix
jasonLaster 44464c8
simplify
jasonLaster 04d7905
remove check
jasonLaster b7419af
remove @replayio/cypress
jasonLaster 16ccc9a
fixes
jasonLaster 9cd4ece
patch args
ryanjduffy dc4cfe2
add upload action
ryanjduffy 74409f8
HACK: coerce types
ryanjduffy 6ed56c2
Merge remote-tracking branch 'origin/replay' into replay
ryanjduffy af74422
simplify
ryanjduffy 02cd9d4
Merge remote-tracking branch 'upstream/main' into replay
ryanjduffy a3b155c
temporary: suppress repo test
ryanjduffy 0113aac
yarn cleanup
ryanjduffy e49d200
add line reporter
ryanjduffy 4a4863a
Update ci.yml
ryanjduffy 8fc8e0a
Merge remote-tracking branch 'upstream/main' into replay
ryanjduffy 6651618
add test metrics
ryanjduffy e60431b
remove type coercion
ryanjduffy 944a57f
Merge branch 'main' into replay
ryanjduffy 060df00
revert playwright downgrade and rebuild yarn.lock
jtoar a7d535f
Update .github/workflows/ci.yml
jtoar 1048976
Merge branch 'main' into copy-of-replay-branch
jtoar ae98834
Merge branch 'main' into copy-of-replay-branch
jtoar e1309c4
Merge branch 'main' into copy-of-replay-branch
jtoar bd3e9d6
Merge branch 'main' into copy-of-replay-branch
jtoar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -208,10 +208,12 @@ jobs: | |
|
|
||
| - name: Run smoke tests on 'rw dev', 'rw serve', 'rw storybook' | ||
| working-directory: ./tasks/smoke-test | ||
| run: npx playwright test | ||
| run: npx playwright test --project ${{ matrix.os == 'ubuntu-latest' && 'replay-chromium' || 'chromium' }} --reporter @replayio/playwright/reporter,line | ||
| env: | ||
| PROJECT_PATH: ${{ steps.setup_test_project.outputs.test_project_path }} | ||
| REDWOOD_DISABLE_TELEMETRY: 1 | ||
| RECORD_REPLAY_METADATA_TEST_RUN_TITLE: Smoke test / ${{ matrix.os }} / node ${{ matrix.node-version }} latest | ||
| RECORD_REPLAY_TEST_METRICS: 1 | ||
|
|
||
| - name: Run `rw info` | ||
| run: | | ||
|
|
@@ -297,6 +299,12 @@ jobs: | |
| working-directory: ${{ steps.setup_test_project.outputs.test_project_path }} | ||
| continue-on-error: true | ||
|
|
||
| - name: Upload Replays | ||
| if: always() | ||
| uses: replayio/[email protected] | ||
| with: | ||
| api-key: rwk_cZn4WLe8106j6tC5ygNQxDpxAwCLpFo5oLQftiRN7OP | ||
|
|
||
| smoke-test-docs: | ||
| needs: only-doc-changes | ||
| if: needs.only-doc-changes.outputs.only-doc-changes == 'true' | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,38 @@ | ||
| import type { PlaywrightTestConfig } from '@playwright/test' | ||
| import { PlaywrightTestConfig, devices} from '@playwright/test' | ||
| import { devices as replayDevices } from "@replayio/playwright"; | ||
|
|
||
| // See https://playwright.dev/docs/test-configuration#global-configuration | ||
| const config: PlaywrightTestConfig = { | ||
| timeout: 90_000, | ||
| expect: { | ||
| timeout: 10 * 1000, | ||
| }, | ||
|
|
||
| // Leaving this here to make debugging easier, by uncommenting | ||
| // use: { | ||
| // launchOptions: { | ||
| // slowMo: 500, | ||
| // headless: false, | ||
| // }, | ||
| // }, | ||
| projects: [ | ||
| { | ||
| name: "replay-firefox", | ||
| use: { ...replayDevices["Replay Firefox"] as any }, | ||
| }, | ||
| { | ||
| name: "replay-chromium", | ||
| use: { ...replayDevices["Replay Chromium"] as any }, | ||
| }, | ||
| { | ||
| name: "firefox", | ||
| use: { ...devices["Desktop Firefox"] }, | ||
| }, | ||
| { | ||
| name: "chromium", | ||
| use: { ...devices["Desktop Chromium"] }, | ||
| }, | ||
| ], | ||
| } | ||
|
|
||
| export default config |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only officially support playwright v1.19 because newer versions do not work with Firefox. If you stick with chromium, you should be okay but keep an eye out for playwright errors if you continue to update the version.
This story will improve in the coming weeks when we update our Firefox fork to the latest ESR (102.2).