Copy of #6173 (smoke tests + replay) #6361
Conversation
jtoar
changed the title
jtoar
changed the title
| "@babel/preset-typescript": "7.18.6", | ||
| "@babel/runtime-corejs3": "7.18.9", | ||
| "@nrwl/nx-cloud": "14.3.0", | ||
| "@playwright/test": "1.25.1", |
There was a problem hiding this comment.
We only officially support playwright v1.19 because newer versions do not work with Firefox. If you stick with chromium, you should be okay but keep an eye out for playwright errors if you continue to update the version.
This story will improve in the coming weeks when we update our Firefox fork to the latest ESR (102.2).
Co-authored-by: Ryan Duffy <[email protected]>
|
@ryanjduffy just letting you know that we'll get this merged soon! We're experiencing some flakiness on the Windows runners in general, so that failing test isn't related to this PR. And we're also holding back on making too many CI changes till we cut another release (which should happen in the next few days) |
|
Sounds good! We've also released a batch of fixes that have improved the stability of all of the redwood recordings. Hopefully that means you'll have a pretty good experience debugging in Replay but of course let us know when you hit issues! |
|
In case y'all hadn't seen this yet, I wanted to call out our GitHub app which will comment on PRs with replay links for passed and/or failed tests. You can always get to them from the action output as well but I find it nice to have them surfaced in the PR too.
https://docs.replay.io/recording-browser-tests-(beta)/pull-request-comments |
|
@ryanjduffy heads up that smoke tests are failing because of a downstream dependency: mswjs/interceptors#285. Was just about to merge this too. I'm sure it'll be resolved soon! |
jtoar
changed the title
@ryanjduffy copy of #6173 with the commit to fix the yarn.lock. Also see #6173 (comment).