-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE-8848] rptest
: adjust compaction settings in datalake/compaction_test
#25075
Open
WillemKauf
wants to merge
1
commit into
redpanda-data:dev
Choose a base branch
from
WillemKauf:datalake_compaction_timeout_fix
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[CORE-8848] rptest
: adjust compaction settings in datalake/compaction_test
#25075
WillemKauf
wants to merge
1
commit into
redpanda-data:dev
from
WillemKauf:datalake_compaction_timeout_fix
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retry command for Build#61801please wait until all jobs are finished before running the slash command
|
CI test resultstest results on build#61801
test results on build#61807
test results on build#61813
|
Because we now schedule adjacent segment compaction after sliding window compaction, this test was having trouble trying to reach the desired number of segments while producing. Increase the timeout as well as the `log_compaction_interval_ms` to allow the test to reach the desired number of segments.
57d7ac8
to
a2fe061
Compare
/ci-repeat 1 |
bharathv
approved these changes
Feb 12, 2025
@bharathv the timeout issues in
Separate issue? |
I think compute_storage.py should look like try:
return [f for f in p.iterdir()]
except FileNotFoundError:
return []
except NotADirectoryError:
return [] but I'm not sure yet, quite tired |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we now schedule adjacent segment compaction after sliding window compaction, this test was having trouble trying to reach the desired number of segments while producing.
Increase the timeout as well as the
log_compaction_interval_ms
to allow the test to reach the desired number of segments.Backports Required
Release Notes