Skip to content

Conversation

@paulohtb6
Copy link
Collaborator

@paulohtb6 paulohtb6 commented Jul 15, 2025

Description

Resolves https://redpandadata.atlassian.net/browse/DOC-1500
Review deadline: July 18th

Page previews

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

@paulohtb6 paulohtb6 requested a review from a team as a code owner July 15, 2025 19:37
@netlify
Copy link

netlify bot commented Jul 15, 2025

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit cb4a1e7
🔍 Latest deploy log https://app.netlify.com/projects/redpanda-docs-preview/deploys/687a4111e2f09d00082402ac
😎 Deploy Preview https://deploy-preview-1210--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 15, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

The documentation updates introduce explicit warnings and configuration instructions regarding a breaking change in Redpanda 25.2: ephemeral SCRAM credentials for the HTTP Proxy have been removed. The changes clarify that, starting in version 25.2, if HTTP Proxy API listeners use authentication_method: none, users must manually configure SASL credentials (scram_username, scram_password, and sasl_mechanism) for HTTP Proxy to authenticate with the Kafka API. The updates include important notices, revised configuration examples, and cross-references in the authentication, upgrade, broker properties, and release notes documentation. Schema Registry behavior remains unchanged.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant HTTP_Proxy
    participant Kafka_API

    User->>HTTP_Proxy: Sends request
    HTTP_Proxy->>Kafka_API: Connects using SASL credentials (if configured)
    alt SASL credentials configured
        Kafka_API-->>HTTP_Proxy: Authenticated connection established
        HTTP_Proxy-->>User: Responds with data
    else No SASL credentials
        Kafka_API-->>HTTP_Proxy: Connection fails (unauthenticated)
        HTTP_Proxy-->>User: Error response
    end
Loading

Assessment against linked issues

Objective Addressed Explanation
Document that ephemeral credentials are no longer supported for HTTP Proxy in 25.2 (DOC-1500)
Provide workaround: document use of sasl_mechanism, scram_password, scram_username (DOC-1500)
Clarify that these credentials are required when authentication_method is none (DOC-1500)
Update Broker Configuration Properties reference for authentication_method and related properties (DOC-1500)

Suggested reviewers

  • micheleRP

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@paulohtb6 paulohtb6 changed the base branch from main to beta July 15, 2025 19:37
@paulohtb6 paulohtb6 requested a review from rockwotj July 15, 2025 19:37
@micheleRP
Copy link
Contributor

This should be noted in the What's New

@paulohtb6
Copy link
Collaborator Author

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 15, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
modules/get-started/pages/release-notes/redpanda.adoc (1)

32-33: Prefer “Redpanda” over “Redpanda Data” for brand consistency

Other parts of the docs use the shorter form (“Redpanda customer support” above). Staying consistent avoids confusing readers.

-Redpanda Data recommends configuring authentication for HTTP Proxy to ensure secure communication with the Kafka API.
+Redpanda recommends configuring authentication for HTTP Proxy to ensure secure communication with the Kafka API.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2a3ca40 and 0eb3704.

📒 Files selected for processing (3)
  • modules/get-started/pages/release-notes/redpanda.adoc (1 hunks)
  • modules/manage/partials/authentication.adoc (3 hunks)
  • modules/upgrade/partials/incompat-changes.adoc (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • modules/upgrade/partials/incompat-changes.adoc
  • modules/manage/partials/authentication.adoc
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: Feediver1
PR: redpanda-data/docs#1153
File: antora.yml:3-5
Timestamp: 2025-07-14T19:28:43.296Z
Learning: In Redpanda docs, during beta releases, the version metadata may intentionally show inconsistencies where the header displays the beta version (e.g., 25.2 Beta) while internal attributes like full-version, latest-redpanda-tag, operator-beta-tag still reference the stable version (e.g., 25.1). This is resolved during the GA merge process when all version references are synchronized.
modules/get-started/pages/release-notes/redpanda.adoc (1)
Learnt from: Feediver1
PR: redpanda-data/docs#1153
File: antora.yml:3-5
Timestamp: 2025-07-14T19:28:43.296Z
Learning: In Redpanda docs, during beta releases, the version metadata may intentionally show inconsistencies where the header displays the beta version (e.g., 25.2 Beta) while internal attributes like full-version, latest-redpanda-tag, operator-beta-tag still reference the stable version (e.g., 25.1). This is resolved during the GA merge process when all version references are synchronized.
🔇 Additional comments (1)
modules/get-started/pages/release-notes/redpanda.adoc (1)

36-40: Anchors verified: no broken links detected

All three anchors (scram_username, scram_password, sasl_mechanism) are present in modules/reference/pages/properties/broker-properties.adoc and match the xref targets in modules/get-started/pages/release-notes/redpanda.adoc. No further changes needed.

@paulohtb6
Copy link
Collaborator Author

@coderabbitai your suggestion is wrong. Redpanda Data stands for the company name, while Redpanda is the product name.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 15, 2025

Tip

For best results, initiate chat on the files or code changes.

@paulohtb6, thank you for the correction! I appreciate you clarifying the distinction between the company name and product name. I'll make sure to use the correct terminology going forward.

🐰💡
/| /|
( . .)
) (
( v )
^^ ^^ ^^


✏️ Learnings added
Learnt from: paulohtb6
URL: https://github.com/redpanda-data/docs/pull/1210

Timestamp: 2025-07-15T20:38:27.426Z
Learning: In Redpanda documentation, "Redpanda Data" refers to the company name, while "Redpanda" refers to the product name. These terms should be used appropriately based on context.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.


🧠 Learnings used
Learnt from: Feediver1
PR: redpanda-data/docs#1153
File: antora.yml:3-5
Timestamp: 2025-07-14T19:28:43.296Z
Learning: In Redpanda docs, during beta releases, the version metadata may intentionally show inconsistencies where the header displays the beta version (e.g., 25.2 Beta) while internal attributes like full-version, latest-redpanda-tag, operator-beta-tag still reference the stable version (e.g., 25.1). This is resolved during the GA merge process when all version references are synchronized.

Learnt from: kbatuigas
PR: redpanda-data/docs#1113
File: modules/manage/partials/iceberg/use-iceberg-catalogs.adoc:100-107
Timestamp: 2025-05-07T01:06:00.937Z
Learning: In AsciiDoc documentation for Redpanda, the syntax `+` and `--` around content blocks within a `[tabs]` section are valid AsciiDoc formatting elements for tabbed content. The `+` after a tab name (like `rpk::`) indicates that the following block belongs to that tab, and the `--` markers enclose the content for that tab. These are not diff artifacts and should not be removed.

Copy link
Contributor

@rockwotj rockwotj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the only thing I would say is to remove the additions about pandaproxy.

@paulohtb6 paulohtb6 requested a review from JakeSCahill July 15, 2025 20:51
Copy link
Contributor

@Feediver1 Feediver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job--let me know if you need me to approve. I know you were awaiting reviews from Michele and Jake.


Schema Registry and HTTP Proxy connect to Redpanda over the Kafka API. For the Kafka username and password, Redpanda uses ephemeral credentials internal to the cluster. Ephemeral credentials are regular SCRAM credentials, but they're only stored in memory and are lost when a broker restarts. When the Schema Registry or HTTP Proxy start up, they broadcast an ephemeral credential to other brokers over the internal RPC. If authentication fails to a particular broker, new ephemeral credentials are sent to that broker, and the service reconnects.

[IMPORTANT]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am checking this part with the Kubernetes team to see what we currently do.

Either way, we'll need to update the paragraph before this section because we will no longer be using ephemeral credentials.

cc @chrisseto

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooooooooh, dear. This is probably going to break some things... AFAIK we set authentication_method: none by default. We really don't like to generate passwords on behalf of users as it's causes a lot of trouble.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really be enabling auth on pandaproxy and kafka API together. The fact that most people don't use pandaproxy and just leave it alone probably means there are a bunch of clusters that have root access to their cluster exposed via pandaproxy.

break some things...

Yeah, but it's for better security and TBH I really suspect very few people actually use the HTTP proxy for anything.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really don't like to generate passwords on behalf of users as it's causes a lot of trouble.

TBH the right fix is not to generate passwords IMO, but to enable auth for HTTP proxy.

====
*Breaking change in Redpanda 25.2:* Ephemeral credentials for HTTP Proxy are removed. If your HTTP Proxy API listeners use `authentication_method: none`, you must configure explicit SASL credentials for HTTP Proxy to authenticate with the Kafka API. Without these credentials, HTTP Proxy attempts unauthenticated connections.
Redpanda Data recommends enabling authentication on both HTTP Proxy and the Kafka API. Without explicit SASL credentials configured, HTTP Proxy attempts unauthenticated connections to the Kafka API.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We seem to have different versions of the same information scattered across all these updates. The one in modules/upgrade/partials/incompat-changes.adoc seems the most complete. Could we single-source that one into the required locations?

Also make sure that this block links to the What's New for details on the change/previous behavior.

@paulohtb6 paulohtb6 merged commit c796187 into beta Jul 18, 2025
7 checks passed
@paulohtb6 paulohtb6 deleted the DOC-1500-ephemeral-auth branch July 18, 2025 12:55
paulohtb6 added a commit that referenced this pull request Jul 30, 2025
Co-authored-by: Paulo Borges <[email protected]>
Co-authored-by: Joyce Fee <[email protected]>
Co-authored-by: Paulo Borges <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants