-
Notifications
You must be signed in to change notification settings - Fork 48
DOC-1356 single source read-only properties in cloud #1128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-1356 single source read-only properties in cloud #1128
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThe changes add explicit documentation tags ( Assessment against linked issues
Possibly related PRs
Suggested reviewers
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
In the Cloud PR, you are trying to single-source these tags, but they don't exist in the doc:
|
oh, right. I'll single source those from the object storage props page on Monday! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just one comment
| --- | ||
|
|
||
|
|
||
| // tag::cluster_id[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We forgot to update the google sheet but cluster_id won't be exposed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I've removed it from Cloud docs
Description
This pull request tags cluster config properties for single sourcing them into Cloud docs (updated in redpanda-data/cloud-docs#295)
Resolves https://redpandadata.atlassian.net/browse/DOC-1356
Review deadline: Monday May 19
Page previews
Cluster Configuration Properties Reference in Cloud
Configure Cluster Properties in Cloud
Checks