Add Databricks pages in Cloud #321
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThis change updates the Antora playbook to source documentation from a feature branch ("DOC-1045-databricks-ga") instead of "main" for the Redpanda documentation repository. It adds a new navigation entry for querying Iceberg topics with Databricks Unity Catalog and introduces a new documentation page that provides instructions for integrating Redpanda Iceberg topics with Databricks, managed through Unity Catalog. No changes to code or exported/public entities are made. Sequence Diagram(s)sequenceDiagram
participant User
participant Documentation Site
participant Redpanda Docs Repo
User->>Documentation Site: Navigate to Iceberg section
Documentation Site->>Redpanda Docs Repo: Fetch "iceberg-topics-databricks-unity.adoc" from feature branch
Redpanda Docs Repo-->>Documentation Site: Serve documentation content
Documentation Site-->>User: Display instructions for Databricks + Unity Catalog integration
Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes found. Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for rp-cloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
local-antora-playbook.yml (1)
18-18: Quote wildcard patterns.
To avoid potential YAML parsing pitfalls, wrap glob patterns likev/*in quotes (e.g.,"v/*").
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
local-antora-playbook.yml(1 hunks)modules/ROOT/nav.adoc(1 hunks)modules/manage/pages/iceberg/iceberg-topics-databricks-unity.adoc(1 hunks)
🔇 Additional comments (4)
local-antora-playbook.yml (1)
18-18: Verify branch list update.
Replacingmainwith the feature branch ensures your new Databricks docs render locally, but confirm this won’t inadvertently excludemain-branch content in CI or production builds.modules/ROOT/nav.adoc (1)
401-401: New navigation link is correct.
The entry for "Query Iceberg Topics with Databricks Unity Catalog" is properly nested under Iceberg and follows existing naming conventions.modules/manage/pages/iceberg/iceberg-topics-databricks-unity.adoc (2)
1-4: Page metadata looks good.
The title, description, andpage-categoriesalign with project conventions and clearly communicate the purpose.
5-5: Validate include directive.
Ensure theinclude::ROOT:manage:iceberg/iceberg-topics-databricks-unity.adoc[tag=single-source]correctly pulls in the intended snippet from the single-source file (and isn’t a self-include). Verify thesingle-sourcetag exists where expected.
Description
This pull request introduces updates to documentation related to Iceberg integration with Databricks Unity Catalog and modifies the Antora playbook configuration. The changes include adding new documentation pages, updating navigation links, and adjusting branch references in the playbook.
Documentation updates:
modules/ROOT/nav.adoc: Added a new navigation link for querying Iceberg topics with Databricks Unity Catalog.modules/manage/pages/iceberg/iceberg-topics-databricks-unity.adoc: Introduced a new documentation page for querying Redpanda topics as Iceberg tables in Databricks managed by Unity Catalog.Antora playbook configuration:
local-antora-playbook.yml: Updated branch references for thedocumentationrepository to include'DOC-1045-databricks-ga'.Resolves https://github.com/redpanda-data/documentation-private/issues/
Review deadline: 11 June
Page previews
https://deploy-preview-321--rp-cloud.netlify.app/redpanda-cloud/manage/iceberg/iceberg-topics-databricks-unity/
Checks