-
Notifications
You must be signed in to change notification settings - Fork 4
Add new Iceberg modes doc in Cloud #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rp-cloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
WalkthroughThe changes introduce a new documentation page titled "Choose an Iceberg Mode" under the Iceberg section. This includes updating the navigation to add a link to the new page and modifying the Antora playbook to source content from a specific feature branch instead of the main branch. No changes were made to exported or public entities in the codebase. Changes
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
modules/shared/images/schema-registry-wire-format.pngis excluded by!**/*.png
📒 Files selected for processing (3)
local-antora-playbook.yml(1 hunks)modules/ROOT/nav.adoc(1 hunks)modules/manage/pages/iceberg/choose-iceberg-mode.adoc(1 hunks)
🔇 Additional comments (2)
modules/manage/pages/iceberg/choose-iceberg-mode.adoc (2)
1-4: Page metadata aligns with Antora standards.
The title, description, categories, and beta flag follow Antora front matter conventions.
6-6: Verify the include directive and tag.
Confirm that thesingle-sourcetag exists in the referenced external snippet to prevent Asciidoctor include failures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Add single sourced content for Iceberg modes. See redpanda-data/docs#1068
Resolves https://github.com/redpanda-data/documentation-private/issues/
Review deadline:
Page previews
Choose an Iceberg Mode
Checks
Summary by CodeRabbit
New Features
Chores