Skip to content

Conversation

@micheleRP
Copy link
Contributor

@micheleRP micheleRP commented Apr 27, 2025

Description

This pull request updates the Azure BYOC cluster creation documentation to improve clarity, add a prerequisite checklist, and enhance the "Next Steps" section.

  • Azure quota and SKU checks: Rephrased instructions to improve clarity, added examples for quota and SKU checks, and included example outputs for both unrestricted and restricted VM SKUs.
  • Prerequisite checklist: Introduced a new interactive checklist to ensure users verify all necessary prerequisites, such as rpk version, Azure role, and vCPU quota.
  • Expanded "Next Steps" section: Added links to configure Azure Private Link, review Azure IAM policies, and learn about rpk commands to guide users after cluster creation.

Resolves https://redpandadata.atlassian.net/browse/DOC-1274
Review deadline: April 28

Page previews

Create BYOC Cluster on Azure

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

@micheleRP micheleRP requested a review from a team as a code owner April 27, 2025 16:41
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 27, 2025

Walkthrough

The documentation for creating a BYOC cluster on Azure was updated to clarify terminology, improve the flow of instructions, and enhance usability. Notable changes include expanded explanations for virtual CPUs, reorganization of notes and instructions for better visibility, an updated section on Azure SKU restrictions with explicit examples, and the addition of an interactive prerequisite checklist. Minor formatting and wording adjustments were made throughout, and the "Next steps" section was expanded with more relevant links. No code or public API changes were introduced.

Changes

File(s) Change Summary
modules/get-started/pages/cluster-types/byoc/azure/create-byoc-cluster-azure.adoc Revised documentation for clarity: expanded vCPU explanation, reorganized notes, updated SKU restriction section with examples, added interactive prerequisite checklist, improved formatting, and expanded "Next steps" links.

Suggested reviewers

  • frenchfrywpepper

Poem

In Azure clouds, the docs now gleam,
With checklists bright and guidance supreme.
vCPUs spelled out, SKUs explained anew,
Notes and links arranged just for you.
A bunny hops through steps so clear—
Cluster creation, have no fear!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 07199bd and 454ed7e.

📒 Files selected for processing (1)
  • modules/get-started/pages/cluster-types/byoc/azure/create-byoc-cluster-azure.adoc (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • modules/get-started/pages/cluster-types/byoc/azure/create-byoc-cluster-azure.adoc
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - rp-cloud
  • GitHub Check: Header rules - rp-cloud
  • GitHub Check: Pages changed - rp-cloud

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify
Copy link

netlify bot commented Apr 27, 2025

Deploy Preview for rp-cloud ready!

Name Link
🔨 Latest commit 454ed7e
🔍 Latest deploy log https://app.netlify.com/sites/rp-cloud/deploys/680e65e1dcb1e400081f718e
😎 Deploy Preview https://deploy-preview-275--rp-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (5)
modules/get-started/pages/cluster-types/byoc/azure/create-byoc-cluster-azure.adoc (5)

69-75: Enhance vCPU quota verification and link styling
The new section explains vCPU requirements clearly, but we can drive action by providing an Azure CLI example and maintain consistency by using an Asciidoc cross-reference instead of a raw URL.

Consider applying a diff like this:

+ Use the Azure CLI to check your current usage:
+
+ [source,bash]
+ ----
+ az vm list-usage -l <region> --output table
+ ----
+ See xref:manage:quotas/view-quotas[Microsoft quotas documentation] for more details.

77-78: Convert inline “NOTE:” to an admonition block
The inline NOTE is informative but inconsistent with other Asciidoc admonitions. Wrapping it in a block enhances readability:

+ [NOTE]
+ ----
+ If you run Redpanda Connect pipelines, or if you <<enable-kafka-connect,enable Kafka Connect>>, Redpanda also deploys an additional node pool.
+ ----

82-87: Unify code-block styling and clarify parameters
This snippet uses [source,bash]/---- while earlier commands use fenced blocks. For consistency, switch to triple backticks and prompt users to replace both region and SKU:

+
+ ```
+ # Replace <region> and <SKU_size> with your target region and VM size
+ az vm list-skus -l <region> --zone --size <SKU_size> --output table
+ ```

106-106: Use a cross-reference for the support-request link
Raw URLs break flow—consider an xref macro to match surrounding links.

+ If you see restrictions, open a xref:troubleshoot/azure/general/region-access-request-process[Microsoft support request] to remove them.

130-131: Refine wording in the new NOTE block
The two bullets are clear but slightly repetitive; tightening the phrasing improves readability.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f9319be and 07199bd.

📒 Files selected for processing (1)
  • modules/get-started/pages/cluster-types/byoc/azure/create-byoc-cluster-azure.adoc (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - rp-cloud
  • GitHub Check: Header rules - rp-cloud
  • GitHub Check: Pages changed - rp-cloud
🔇 Additional comments (3)
modules/get-started/pages/cluster-types/byoc/azure/create-byoc-cluster-azure.adoc (3)

90-96: Example output (no restrictions) looks good
The table sample accurately demonstrates the expected “None” restrictions state and is clear.


98-104: Example output (with restrictions) is informative
The restricted output example correctly flags “NotAvailableForSubscription.” Good clarity on what to look for.


108-117: Verify interactive checklist support
The new interactive checklist is a great way to track prerequisites. Please confirm that [%interactive] is supported in your build pipeline (Netlify/Asciidoc toolchain).

@micheleRP micheleRP mentioned this pull request Apr 27, 2025
4 tasks
Copy link
Contributor

@kbatuigas kbatuigas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@micheleRP micheleRP merged commit 1ffac11 into main Apr 28, 2025
6 checks passed
@micheleRP micheleRP deleted the DOC-1274-Azure-doc-edits branch April 28, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants