Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users use a env vars or a config as well as cli flags #74

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nocturnalastro
Copy link
Collaborator

No description provided.

@nocturnalastro nocturnalastro marked this pull request as ready for review August 17, 2023 09:31
@nocturnalastro nocturnalastro requested a review from crwr45 August 17, 2023 09:34
Copy link
Contributor

@crwr45 crwr45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little bit of slightly inconsistent naming, otherwise this looks like a good change.

OutputFile string `mapstructure:"output_file"`
Duration string `mapstructure:"duration"`
CollectorNames []string `mapstructure:"collectors"`
PollInterval int `mapstructure:"poll_rate"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inconsistent use of rate/interval in the naming

@nocturnalastro nocturnalastro marked this pull request as draft October 3, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants