fixup! Allow users use a env vars or a config file instead of cli flags

Author: nocturnalastro

pkg/cmd/collect.go

@@ -61,25 +61,22 @@ var collectCmd = &cobra.Command{
 	Run: func(cmd *cobra.Command, args []string) {
 		runtimeConfig := &CollectionParams{}
 		err := populateParams(cmd, runtimeConfig)
-		if err == nil {
-			requestedDuration, err := time.ParseDuration(runtimeConfig.Duration)
-			if requestedDuration.Nanoseconds() < 0 {
-				log.Panicf("Requested duration must be positive")
-			}
-			utils.IfErrorExitOrPanic(err)
-
-			collectionRunner := runner.NewCollectorRunner(runtimeConfig.CollectorNames)
-			collectionRunner.Run(
-				runtimeConfig.KubeConfig,
-				runtimeConfig.OutputFile,
-				requestedDuration,
-				runtimeConfig.PollInterval,
-				runtimeConfig.DevInfoAnnouceInterval,
-				runtimeConfig.PTPInterface,
-				runtimeConfig.UseAnalyserJSON,
-			)
+		utils.IfErrorExitOrPanic(err)
+		requestedDuration, err := time.ParseDuration(runtimeConfig.Duration)
+		utils.IfErrorExitOrPanic(err)
+		if requestedDuration.Nanoseconds() < 0 {
+			log.Panicf("Requested duration must be positive")
 		}
-
+		collectionRunner := runner.NewCollectorRunner(runtimeConfig.CollectorNames)
+		collectionRunner.Run(
+			runtimeConfig.KubeConfig,
+			runtimeConfig.OutputFile,
+			requestedDuration,
+			runtimeConfig.PollInterval,
+			runtimeConfig.DevInfoAnnouceInterval,
+			runtimeConfig.PTPInterface,
+			runtimeConfig.UseAnalyserJSON,
+		)
 	},
 }
 
@@ -127,7 +124,6 @@ func init() { //nolint:funlen // Allow this to get a little long
 
 	defaultCollectorNames := make([]string, 0)
 	defaultCollectorNames = append(defaultCollectorNames, runner.All)
-
 	collectCmd.Flags().StringSliceVarP(
 		&collectorNames,
 		"collector",