Skip to content

adding method to see if a given string violates Red Hat Trademark(s) #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2024
Merged

adding method to see if a given string violates Red Hat Trademark(s) #1219

merged 1 commit into from
Dec 6, 2024

Conversation

@acornett21
Copy link
Contributor

@acornett21 acornett21 commented Dec 2, 2024 •
edited
Loading

Motivation

We need to start enforcing our trademark rights for Red Hat verbiage in various checks within the container policy. This PR is the starting point for that work.

Changes

  • Added a global method that contains the same validation as pyxis (this might become un-exported once full requirements are presented by the business)
  • Updated HasRequiredLabels check to check for trademark violations of various labels.
  • Added maintainer to required label field in HasRequiredLabels check
  • Added new HasProhibitedContainerName check

@acornett21 acornett21 requested review from bcrochet and komish December 2, 2024 20:17
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2024
@openshift-ci
Copy link

openshift-ci bot commented Dec 2, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2024
@dcibot
Copy link

dcibot commented Dec 2, 2024

from change #1219:

@ramperher ramperher mentioned this pull request Dec 3, 2024
Merged
@coveralls
Copy link

coveralls commented Dec 3, 2024 •
edited
Loading

Coverage Status

coverage: 84.611% (+0.2%) from 84.43%
when pulling 314fd39 on acornett21:red_hat_trademark
into 24e32ea on redhat-openshift-ecosystem:main.

@acornett21 acornett21 force-pushed the red_hat_trademark branch 3 times, most recently from a682a67 to 0972357 Compare December 3, 2024 17:32
@dcibot
Copy link

dcibot commented Dec 3, 2024

from change #1219:

@dcibot
Copy link

dcibot commented Dec 3, 2024

from change #1219:

@acornett21 acornett21 marked this pull request as ready for review December 3, 2024 20:54
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 3, 2024
@openshift-ci openshift-ci bot requested a review from tonytcampbell December 3, 2024 20:54
@dcibot
Copy link

dcibot commented Dec 3, 2024

from change #1219:

@dcibot
Copy link

dcibot commented Dec 4, 2024

from change #1219:

komish
komish reviewed Dec 4, 2024
View reviewed changes
komish
komish reviewed Dec 4, 2024
View reviewed changes
komish
komish reviewed Dec 4, 2024
View reviewed changes
komish
komish reviewed Dec 4, 2024
View reviewed changes
komish
komish reviewed Dec 4, 2024
View reviewed changes
komish
komish reviewed Dec 4, 2024
View reviewed changes
komish
komish reviewed Dec 4, 2024
View reviewed changes
@dcibot
Copy link

dcibot commented Dec 4, 2024

from change #1219:

@dcibot
Copy link

dcibot commented Dec 5, 2024

from change https://github.com/dci-labs/dallas-pipelines/pull/1299:

@ramperher
Copy link

from change dci-labs/dallas-pipelines#1299:

We've moved here to simple-demo-operator:v0.0.8 and now the test is passing, feel free to merge

@dcibot
Copy link

dcibot commented Dec 5, 2024

from change #1219:

@komish
Copy link
Contributor

komish commented Dec 5, 2024

@ramperher Is this still passing?

komish
komish approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2024
@acornett21
Copy link
Contributor Author

@ramperher Is this still passing?

The sha seems to have reverted back to the old one.

skattoju
skattoju reviewed Dec 6, 2024
View reviewed changes
@acornett21
adding method to see if a given string violates Red Hat Trademark(s) …
314fd39 
…and incorporating into container checks

Signed-off-by: Adam D. Cornett <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2024
@openshift-ci
Copy link

openshift-ci bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, komish, skattoju

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [acornett21,komish,skattoju]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acornett21 acornett21 merged commit ee9611b into redhat-openshift-ecosystem:main Dec 6, 2024
6 checks passed
@dcibot
Copy link

dcibot commented Dec 6, 2024

from change #1219:

@aroberts87 aroberts87 mentioned this pull request Dec 11, 2024
Merged
1 task
@chaitanya1731 chaitanya1731 mentioned this pull request Mar 31, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@komish komish komish approved these changes

@skattoju skattoju skattoju approved these changes

@bcrochet bcrochet Awaiting requested review from bcrochet

@tonytcampbell tonytcampbell Awaiting requested review from tonytcampbell

Assignees

@komish komish

@skattoju skattoju

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@acornett21 @dcibot @coveralls @ramperher @komish @skattoju