Add schema info to diagnostics

[evidolob]

Fix: #310

Also fix: redhat-developer/vscode-yaml#373 partially, as I add YAML for YAML syntax errors

Demo:

Schema with title:

Local schema:

Yaml error:

Problems:

Kubernetos schema:

[coveralls]

Coverage increased (+0.4%) to 78.016% when pulling 23529fd on evidolob:add-schema-to-diagnostics into b9fda68 on redhat-developer:master.

[JPinkney]

I think this is a really cool feature. I've been playing around with it and it seems like it works perfectly when theres one schema associated to the file but it has a bit of trouble when there's multiple schemas associated to a file.

E.g.

"yaml.schemas": {
    "kubernetes": "test.yaml",
    "https://json.schemastore.org/composer": "test.yaml"
}

and then with content

abandoned: v1
archive:
  exclude:
    asd: asd

you'll get yaml-schema: schemaservice://combinedschema/file%3A///home/joshpinkney/Documents/Work/Schemas/test.yaml in the error message when you'd expect the composer schema.

Also if you did:

"yaml.schemas": {
    "kubernetes": "prometheus.yaml"
},

with content

apiVersion: v1
kind: Pod
metadata:
  name: False

you'll get yaml-schema: This is because the prometheus.yaml schema from the schema store and the kubernetes schema are both applied to prometheus.yaml

[evidolob]

@JPinkney Thx, I miss that file may have multiple schemas, going to fix that

[evidolob]

@JPinkney
Now it should resolve schema correctly:

[evidolob]

@gorkem @JPinkney @joshuawilson
Full k8s url:

[JPinkney]

Generally, it looks good to me. I tried it out locally and everything seems to be working almost perfectly. I only issue I ran into was in a test scenario with a .drone.yml file where I had yaml.settings as:

"yaml.schemas": {
    "kubernetes": ".drone.yml"
},

with the content:

apiVersion: v1
kind: Deployment

where I was getting error message Property apiVersion is not allowed.YAML when hovering apiVersion and when hovering deployment I got

Value is not accepted. Valid values: "pipeline".: YAML

maybe in this case the validator matches a little bit of the drone ci and the kubernetes schema and cannot decide which one it is matching? I'm not sure

[JPinkney]

In this case won't label always just end up being whatever url.toString() is?

[evidolob]

Yes, it is done for local files, I assume the path /home/user/folder/schema.json will be more informative than file:///home/user/folder/schema.json. If URI has different schema than it used as is.

[evidolob]

@JPinkney I fix that, can you check again?

[JPinkney]

Tested again and now everything seems to be working as expected!