Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provenance for Diagnostic messages #100

Closed
shaded-enmity opened this issue Jul 11, 2018 · 3 comments
Closed

Provenance for Diagnostic messages #100

shaded-enmity opened this issue Jul 11, 2018 · 3 comments

Comments

@shaded-enmity
Copy link

We first touched this topic in #96 (comment) and I've been wondering what would be the possible solutions here. Just to properly set the context here, the problem is that LSP extensions like vscode-yaml emit diagnostic messages based on schemas provided by 3rd parties, however these messages provide no provenance as to from what 3rd party. The idea here is that we could re-purpose some fields from the original LSP spec1 - either the source field or the recently added relatedInfomation field to convey such information.

I've already started annotating schemas generated by ansible-schema-generator with a top-level $contact object:

'$contact': {
    'issues': 'https://github.com/shaded-enmity/ansible-schema-generator/issues',
    'name': 'Pavel Odvody'
}

However I feel that we might want to get broader consensus here and I'm still playing with the idea that the correct place for provenance information might be a top-level key in the LSP spec itself - to keep an account of the fact that the data which are driving the extension might be coming from a 3rd party.

@JPinkney
Copy link
Contributor

I think that's a really great idea. My only concern is that i'm not entirely sure how many language servers rely on things coming from a third party. I think vscode-yaml and the yaml-language-server are more of the exception rather then the norm. I know that the json language service uses schemas as well but I believe they don't pull from the schema store.

@JPinkney
Copy link
Contributor

@shaded-enmity A feature was added a little bit ago that does this: redhat-developer/yaml-language-server#326. Do you think this feature covers everything?

@gorkem
Copy link
Collaborator

gorkem commented Dec 18, 2020

Closing as fixed

@gorkem gorkem closed this as completed Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants