-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problems reported must include information about schema being used #412
Comments
It is not possible with Language Server(the only way is adding custom extension to protocol) I'm going to experiment with CodeLens |
I am not sure how it would look using CodeLens. I am asking because I want to assure that when someone clicks on an entry from the found problems panel, I do expect to see somewhere which schema was used for that document. The file is opened and the error line is selected automatically, but if codelends display the schema at the top of the file, it will mean that is not visible to the user. We need to be sure we make the schema visible because otherwise we will be inundated with bug reports about issues that are specific to those schemas and not to the yaml-languages-sever or the vscode-yaml extensions. |
That is already done with #395 CodeLens will contain info about schemas used to validate and allow to navigate to it, even if file doesn't have an error. |
…elens Signed-off-by: Yevhen Vydolob <[email protected]>
* #412 Implement CodeLens, show all json schemas in codelens Signed-off-by: Yevhen Vydolob <[email protected]> * Fix review comments Signed-off-by: Yevhen Vydolob <[email protected]> * delete commented code Signed-off-by: Yevhen Vydolob <[email protected]> * Use 'isBooelan' as type gard Signed-off-by: Yevhen Vydolob <[email protected]> * fix tests Signed-off-by: Yevhen Vydolob <[email protected]>
Is your enhancement related to a problem? Please describe.
Based on discussions from #310 (comment) we identified a real need to disclose the schema that was used for a particular file.
Describe the solution you would like
I will list several approaches with the note that addressing any of them should be enough.
Information we need to expose:
We should not underestimate the chance of using the wrong schema due to wrong patterns, so all of these will help user identify the source of the problem and avoid creating
UI Locations:
Describe alternatives you have considered
Additional context
The text was updated successfully, but these errors were encountered: