-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load schema content contributed by other extensions #451
Load schema content contributed by other extensions #451
Conversation
Signed-off-by: Yevhen Vydolob <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been playing around with this change and it's really great 👍
} | ||
|
||
it('should handle "json-schema" url', async () => { | ||
const docUri = getDocUri('completion/completion.yaml'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you run this test against windows you might need ${path.sep}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, test on windows passed successfully
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Signed-off-by: Yevhen Vydolob <[email protected]>
Signed-off-by: Yevhen Vydolob <[email protected]>
What does this PR do?
Add ability to open JSON Schema content contributed by other extensions with ExtensionAPI.
Depends on redhat-developer/yaml-language-server#424
What issues does this PR fix or reference?
redhat-developer/yaml-language-server#412
Is it tested? How?
With test. To manual test, open any yaml which has json schema contributed with ExtensionAPI(any k8s yaml with k8s extension installed) and click on codelens over first line, it should open JSON Schema in editor tab.