Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: odo init overwrites personalized configuration when downloading starter project #6800

Merged
merged 6 commits into from
May 11, 2023
Merged

Fix: odo init overwrites personalized configuration when downloading starter project #6800

merged 6 commits into from
May 11, 2023

Conversation

valaparthvi
Copy link
Contributor

@valaparthvi valaparthvi commented May 8, 2023 •
edited by rm3l
Loading

What type of PR is this:
/kind bug

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6799
Fixes #6752

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented May 8, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 21614bc
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/645cfd1df267760008c43b8e

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label May 8, 2023
@openshift-ci openshift-ci bot requested review from anandrkskd and rm3l May 8, 2023 15:24
@odo-robot
Copy link

odo-robot bot commented May 8, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit f09e6d4 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 8, 2023 •
edited
Loading

NoCluster Tests on commit f09e6d4 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 8, 2023 •
edited
Loading

Unit Tests on commit f09e6d4 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 8, 2023 •
edited
Loading

Validate Tests on commit f09e6d4 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 8, 2023 •
edited
Loading

Windows Tests (OCP) on commit f09e6d4 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 8, 2023 •
edited
Loading

Kubernetes Tests on commit f09e6d4 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 8, 2023 •
edited
Loading

OpenShift Tests on commit f09e6d4 finished successfully.
View logs: TXT HTML

rm3l
rm3l requested changes May 10, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just had one comment about the unit tests.

pkg/registry/registry_test.go Outdated Show resolved Hide resolved
@valaparthvi valaparthvi force-pushed the fix-starterproject-contains-devfile branch from ed09fef to 2868952 Compare May 11, 2023 07:05
@ritudes
Adding intergration tests for personalizing configurations with odo init
554a8a6 
Signed-off-by: Ritu Deshmukh <[email protected]>

Modified changes

Signed-off-by: Ritu Deshmukh <[email protected]>

Update tests/integration/interactive_init_test.go

Co-authored-by: Parthvi Vala <[email protected]>

Update tests/integration/interactive_init_test.go

Co-authored-by: Parthvi Vala <[email protected]>

Update interactive_init_test.go

Update interactive_init_test.go

Update interactive_init_test.go

Update tests/integration/interactive_init_test.go

Co-authored-by: Parthvi Vala <[email protected]>

Update interactive_init_test.go
@odo-robot
Copy link

odo-robot bot commented May 11, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 7ff460b finished successfully.
View logs: TXT HTML

ritudes and others added 2 commits May 11, 2023 14:18
@ritudes
Updated changes
9ff3725 
Signed-off-by: Ritu Deshmukh <[email protected]>
@valaparthvi
Attempt at fixing interactive tests
de3422c 
Signed-off-by: Parthvi Vala <[email protected]>
@valaparthvi valaparthvi force-pushed the fix-starterproject-contains-devfile branch from 6661da6 to de3422c Compare May 11, 2023 12:41
@valaparthvi @rm3l
Add multiple devfile version check
21614bc 
Co-authored-by: Armel Soro <[email protected]>
Signed-off-by: Parthvi Vala <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 11, 2023
@openshift-merge-robot openshift-merge-robot merged commit 0cdc2e5 into redhat-developer:main May 11, 2023
@valaparthvi valaparthvi mentioned this pull request May 15, 2023
Closed
3 tasks
@rm3l rm3l mentioned this pull request Jun 14, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

Assignees

@rm3l rm3l

Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
4 participants
@valaparthvi @rm3l @openshift-merge-robot @ritudes