Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop test as soon as expectation is verified #6891

Merged

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Jun 14, 2023

What type of PR is this:

/kind bug
/area testing

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6890

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Jun 14, 2023

Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit b4528e9
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6489eae24133ef00085d087f
😎 Deploy Preview https://deploy-preview-6891--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering labels Jun 14, 2023
@openshift-ci openshift-ci bot requested review from anandrkskd and valaparthvi June 14, 2023 07:37
@odo-robot
Copy link

odo-robot bot commented Jun 14, 2023

OpenShift Unauthenticated Tests on commit 67934c2 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 14, 2023

NoCluster Tests on commit 67934c2 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 14, 2023

Unit Tests on commit 67934c2 finished successfully.
View logs: TXT HTML

@feloy feloy requested a review from rm3l June 14, 2023 07:50
@odo-robot
Copy link

odo-robot bot commented Jun 14, 2023

Validate Tests on commit 67934c2 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 14, 2023

Kubernetes Tests on commit 67934c2 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 14, 2023

OpenShift Tests on commit 67934c2 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 14, 2023

Windows Tests (OCP) on commit 67934c2 finished with errors.
View logs: TXT HTML

@feloy feloy force-pushed the tests-6890/nightly-test branch from 2a0420c to e73e9cd Compare June 14, 2023 13:04
@feloy feloy changed the title Ask version for PHP Devfile Stop test as soon as expectation is verified Jun 14, 2023
@feloy feloy requested a review from rm3l June 14, 2023 13:04
@feloy feloy force-pushed the tests-6890/nightly-test branch from e73e9cd to b4528e9 Compare June 14, 2023 16:29
@feloy feloy requested a review from rm3l June 14, 2023 16:29
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.8% 2.8% Duplication

@odo-robot
Copy link

odo-robot bot commented Jun 14, 2023

Kubernetes Docs Tests on commit 63c8e27 finished with errors.
View logs: TXT HTML

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 15, 2023
@rm3l
Copy link
Member

rm3l commented Jun 15, 2023

...

  [FAILED] registry_list_output.mdx
  Expected
      <string>: Â Â strings.Join({
      Â Â 	... // 106 identical bytes
      Â Â 	"                          VERSIONS\nnodejs-react  StagingRegistry",
      Â Â 	"         React is a free and open-source front-en...  2.0.2, 2.1",
      +Â 	".0, 2.2",
      Â Â 	".0\nnodejs-react  DefaultDevfileRegistry  React is a free and ope",
      Â Â 	"n-source front-en...  2.0.2, 2.1.0\n```\n",
      Â Â }, "")
      
  to be empty
  In [It] at: /go/odo_1/tests/documentation/command-reference/doc_command_reference_init_test.go:189 @ 06/14/23 17:29:09.71
------------------------------
•Spawning '/go/bin/odo init' from /tmp/2694570575
•••••Spawning '/go/bin/odo delete project odo-dev' from /tmp/4056405758
•Spawning '/go/bin/odo delete namespace odo-dev' from /tmp/1027745922
•••Spawning '/go/bin/odo init' from /tmp/852964006
•••••

Summarizing 1 Failure:
  [FAIL] doc command reference odo init Non Interactive Mode fetching devfile from a registry when setting up the registry [It] Fetch Devfile from any registry of the list [nocluster]
  /go/odo_1/tests/documentation/command-reference/doc_command_reference_init_test.go:189

Doc automation tests issue - reported in #6876

/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

@openshift-ci
Copy link

openshift-ci bot commented Jun 15, 2023

@rm3l: Overrode contexts on behalf of rm3l: Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

In response to this:

...

 [FAILED] registry_list_output.mdx
 Expected
     <string>: Â Â strings.Join({
     Â Â 	... // 106 identical bytes
     Â Â 	"                          VERSIONS\nnodejs-react  StagingRegistry",
     Â Â 	"         React is a free and open-source front-en...  2.0.2, 2.1",
     +Â 	".0, 2.2",
     Â Â 	".0\nnodejs-react  DefaultDevfileRegistry  React is a free and ope",
     Â Â 	"n-source front-en...  2.0.2, 2.1.0\n```\n",
     Â Â }, "")
     
 to be empty
 In [It] at: /go/odo_1/tests/documentation/command-reference/doc_command_reference_init_test.go:189 @ 06/14/23 17:29:09.71
------------------------------
•Spawning '/go/bin/odo init' from /tmp/2694570575
•••••Spawning '/go/bin/odo delete project odo-dev' from /tmp/4056405758
•Spawning '/go/bin/odo delete namespace odo-dev' from /tmp/1027745922
•••Spawning '/go/bin/odo init' from /tmp/852964006
•••••

Summarizing 1 Failure:
 [FAIL] doc command reference odo init Non Interactive Mode fetching devfile from a registry when setting up the registry [It] Fetch Devfile from any registry of the list [nocluster]
 /go/odo_1/tests/documentation/command-reference/doc_command_reference_init_test.go:189

Doc automation tests issue - reported in #6876

/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l
Copy link
Member

rm3l commented Jun 15, 2023

[FAILED] Timed out after 420.000s.
  Expected
      <string>:   __
       /  \__     Developing using the "hmyitr" Devfile
       \__/  \    Namespace: cmd-dev-test468jix
       /  \__/    odo version: v3.11.0
       \__/
      
      ↪ Running on the cluster in Dev mode
       •  Waiting for Kubernetes resources  ...
       âš   Pod is Pending
       âš   0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling.
       âš   0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling.
       âš   0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling.
       âš   AttachVolume.Attach failed for volume "pvc-749a3dd3-69d6-4702-b08d-cffc6d2d5122" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-c4b78560-c7c1-4002-9923-297cdef71201
       âš   Unable to attach or mount volumes: unmounted volumes=[odo-projects], unattached volumes=[odo-shared-data kube-api-access-d622r odo-projects]: timed out waiting for the condition
       âš   AttachVolume.Attach failed for volume "pvc-749a3dd3-69d6-4702-b08d-cffc6d2d5122" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-c4b78560-c7c1-4002-9923-297cdef71201
       âš   Unable to attach or mount volumes: unmounted volumes=[odo-projects], unattached volumes=[odo-projects odo-shared-data kube-api-access-d622r]: timed out waiting for the condition
       âš   AttachVolume.Attach failed for volume "pvc-749a3dd3-69d6-4702-b08d-cffc6d2d5122" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-c4b78560-c7c1-4002-9923-297cdef71201
       âš   Unable to attach or mount volumes: unmounted volumes=[odo-projects], unattached volumes=[odo-shared-data kube-api-access-d622r odo-projects]: timed out waiting for the condition
      
  to contain substring
      <string>: [Ctrl+c] - Exit

Issues with volume mounting on OpenShift clusters - should not be related to the tests here, but this is something we need to investigate.

EDIT: reported in #6894

/override OpenShift-Integration-tests/OpenShift-Integration-tests
/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented Jun 15, 2023

@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests, windows-integration-test/Windows-test

In response to this:

[FAILED] Timed out after 420.000s.
 Expected
     <string>:   __
      /  \__     Developing using the "hmyitr" Devfile
      \__/  \    Namespace: cmd-dev-test468jix
      /  \__/    odo version: v3.11.0
      \__/
     
     ↪ Running on the cluster in Dev mode
      •  Waiting for Kubernetes resources  ...
      âš   Pod is Pending
      âš   0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling.
      âš   0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling.
      âš   0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling.
      âš   AttachVolume.Attach failed for volume "pvc-749a3dd3-69d6-4702-b08d-cffc6d2d5122" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-c4b78560-c7c1-4002-9923-297cdef71201
      âš   Unable to attach or mount volumes: unmounted volumes=[odo-projects], unattached volumes=[odo-shared-data kube-api-access-d622r odo-projects]: timed out waiting for the condition
      âš   AttachVolume.Attach failed for volume "pvc-749a3dd3-69d6-4702-b08d-cffc6d2d5122" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-c4b78560-c7c1-4002-9923-297cdef71201
      âš   Unable to attach or mount volumes: unmounted volumes=[odo-projects], unattached volumes=[odo-projects odo-shared-data kube-api-access-d622r]: timed out waiting for the condition
      âš   AttachVolume.Attach failed for volume "pvc-749a3dd3-69d6-4702-b08d-cffc6d2d5122" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-c4b78560-c7c1-4002-9923-297cdef71201
      âš   Unable to attach or mount volumes: unmounted volumes=[odo-projects], unattached volumes=[odo-shared-data kube-api-access-d622r odo-projects]: timed out waiting for the condition
     
 to contain substring
     <string>: [Ctrl+c] - Exit

Issues with volume mounting on OpenShift clusters - should not be related to the tests here, but this is something we need to investigate.

/override OpenShift-Integration-tests/OpenShift-Integration-tests
/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 24db607 into redhat-developer:main Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing nightly test
3 participants