Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List Routes/Ingresses created by odo deploy in odo describe component #6244

Merged
merged 22 commits into from
Nov 18, 2022
Merged

List Routes/Ingresses created by odo deploy in odo describe component #6244

merged 22 commits into from
Nov 18, 2022

Conversation

valaparthvi
Copy link
Contributor

What type of PR is this:
/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #5990

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

  1. Use the devfiles in this PR to deploy the component with odo deploy.
  2. Run odo describe component to see if the URLs are printed.

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Oct 21, 2022
@openshift-ci openshift-ci bot requested review from anandrkskd and dharmit October 21, 2022 08:07
@netlify
Copy link

netlify bot commented Oct 21, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit f3c8f3b
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63775fc3fc7dec0009372002
😎 Deploy Preview https://deploy-preview-6244--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@odo-robot
Copy link

odo-robot bot commented Oct 21, 2022 •
edited
Loading

Unit Tests on commit ec36ac0 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 21, 2022 •
edited
Loading

Validate Tests on commit ec36ac0 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 21, 2022 •
edited
Loading

Kubernetes Tests on commit ec36ac0 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 21, 2022 •
edited
Loading

Windows Tests (OCP) on commit ec36ac0 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 21, 2022 •
edited
Loading

OpenShift Tests on commit ec36ac0 finished successfully.
View logs: TXT HTML

@valaparthvi valaparthvi reopened this Oct 26, 2022
rm3l
rm3l requested changes Oct 26, 2022
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments below.

Also, can you update the "Deploying application" User Guides to mention this new capability? At least for OpenShift, this will be helpful to determine how to access the application, which was one of the main reasons behind this issue.

pkg/odo/cli/describe/component.go Outdated Show resolved Hide resolved
pkg/odo/cli/describe/component.go Outdated Show resolved Hide resolved
tests/examples/source/devfiles/nodejs/devfile-deploy-ingress.yaml Show resolved Hide resolved
pkg/api/component.go Outdated Show resolved Hide resolved
pkg/component/component.go Outdated Show resolved Hide resolved
tests/integration/cmd_describe_component_test.go Outdated Show resolved Hide resolved
tests/integration/cmd_describe_component_test.go Outdated Show resolved Hide resolved
valaparthvi and others added 14 commits November 17, 2022 15:08
@valaparthvi
List routes/ingresses deployed by odo in the describe output
d39e605
@valaparthvi
Remove ListDyanmicResourcesFromSelector and use ListDyanmicResources …
d0e4dff 
…instead by add a selector argument to it

Signed-off-by: Parthvi Vala <[email protected]>
@valaparthvi @rm3l
Update pkg/api/component.go
7c82599 
Co-authored-by: Armel Soro <[email protected]>
@valaparthvi
Replace DyanmicClient for ingress with a kubeclient
343af02
@valaparthvi
Show ing/route name if *.hosts is empty
e26e580
@valaparthvi
Change API format
3c4f042
@valaparthvi
Ignore owned ing/routes
a1a2b09
@valaparthvi
Add devfile with default backend ingress
88c1c14
@valaparthvi
Add tests for named describe command
3f27fa3
@valaparthvi
mock kclient
1b1e247
@valaparthvi
Fix integration test failure
a563acd
@valaparthvi
Fix integration test failure with registry
35e3b6d
@valaparthvi
Add test for ingress with default backend
4d0bbaf
@valaparthvi
Add unit test for ListRoutesAndIngresses
4325acc
@odo-robot
Copy link

odo-robot bot commented Nov 17, 2022 •
edited
Loading

NoCluster Tests on commit ec36ac0 finished successfully.
View logs: TXT HTML

@valaparthvi @feloy
Update pkg/component/component.go
8fb5dbe 
Co-authored-by: Philippe Martin <[email protected]>
@valaparthvi
Copy link
Contributor Author

/retest-required

@valaparthvi valaparthvi requested a review from feloy November 18, 2022 06:06
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 18, 2022
@feloy feloy closed this Nov 18, 2022
@feloy feloy reopened this Nov 18, 2022
@valaparthvi valaparthvi reopened this Nov 18, 2022
rm3l
rm3l reviewed Nov 18, 2022
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this. LGTM feature-wise.
Added a few minor comments.

Also, I think there is one last thing missing from the Acceptance Criteria:

We should update the Quickstart Guide accordingly, by showing how to access the deployed application

Could you update the "Deploying application" guides accordingly? Currently, they are mentioning Test your application by visiting the DOMAIN_NAME variable that you had set in the devfile.yaml., but this won't work with OpenShift (we are not using DOMAIN_NAME). So using odo describe component could be helpful (at least for OpenShift)
Maybe by adding a "Step 5. Accessing the application" section in those guides, and tabs for Kubernetes and OpenShift?

(But this can be done in a subsequent PR if you prefer to have this merged first).

pkg/odo/cli/describe/component.go Outdated Show resolved Hide resolved
pkg/odo/cli/describe/component.go Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 18, 2022
@valaparthvi
Copy link
Contributor Author

(But this can be done in a subsequent PR if you prefer to have this merged first).

Yes, please. I'll open a separate PR for this.

rm3l
rm3l approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 18, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Nov 18, 2022
@rm3l rm3l mentioned this pull request Nov 18, 2022
Closed
@rm3l
Copy link
Member

rm3l commented Nov 18, 2022

(But this can be done in a subsequent PR if you prefer to have this merged first).

Yes, please. I'll open a separate PR for this.

Ok. I created this issue for the record: #6319

@valaparthvi valaparthvi reopened this Nov 18, 2022
@valaparthvi valaparthvi reopened this Nov 18, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@rm3l
Copy link
Member

rm3l commented Nov 18, 2022

/override ci/prow/v4.11-integration-e2e

Tests passing on IBM Cloud.

@openshift-ci
Copy link

openshift-ci bot commented Nov 18, 2022

@rm3l: Overrode contexts on behalf of rm3l: ci/prow/v4.11-integration-e2e

In response to this:

/override ci/prow/v4.11-integration-e2e

Tests passing on IBM Cloud.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit ec50353 into redhat-developer:main Nov 18, 2022
@kadel kadel mentioned this pull request Dec 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@feloy feloy feloy approved these changes

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

@dharmit dharmit Awaiting requested review from dharmit

Assignees

@rm3l rm3l

@feloy feloy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

odo describe component: List Routes/Ingresses deployed by odo deploy
4 participants
@valaparthvi @rm3l @feloy @openshift-merge-robot