Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odo describe component: List Routes/Ingresses deployed by odo deploy #5990

Closed
4 tasks
Tracked by #5994
kadel opened this issue Jul 29, 2022 · 3 comments · Fixed by #6244
Closed
4 tasks
Tracked by #5994

odo describe component: List Routes/Ingresses deployed by odo deploy #5990

kadel opened this issue Jul 29, 2022 · 3 comments · Fixed by #6244
Assignees
Labels
estimated-size/XS (1-5) Rough sizing for Epics. Less than one sprint of work for one person, but smaller than S. kind/user-story An issue of user-story kind priority/Medium Nice to have issue. Getting it done before priority changes would be great.
Milestone

Comments

@kadel
Copy link
Member

kadel commented Jul 29, 2022

/kind user-story

User Story

  • As an odo user
  • I want to be able to list Routes/Ingresses URLs that were deployed after executing odo deploy
  • So that I know where I can access my application.

Context

Users that went through the Quickstart Guide were wondering how to access their application. For Kubernetes Ingresses, this is fine since the user knows which domain name they used; But for Openshift Routes, the URL is generated automatically; the user currently has no way to get the routes, apart from running oc get routes or navigating to the Openshift web console.

Acceptance Criteria

  • It should list the Ingresses and Routes. See examples below.
  • Ingresses and Routes must be visible only if the running mode contains "Deploy"
  • It should include such information in the JSON output as well
  • We should update the Quickstart Guide accordingly, by showing how to access the deployed application

Examples

❯ odo describe component

Name: my-java-maven-springboot
Display Name: Spring Boot®
Project Type: spring
Language: java
Version: 1.1.0
Description: Spring Boot® using Java
Tags: Java, Spring

Running in: Dev, Deploy

Forwarded ports:
 •  127.0.0.1:40002 -> tools:8080

Supported odo features:
 •  Dev: true
 •  Deploy: true
 •  Debug: true

Container components:
 •  tools

Kubernetes components:
 •  outerloop-deployment
 •  outerloop-service
 •  outerloop-k8s-url
 •  outerloop-ocp-url

Kubernetes Ingresses:
 •  my-java-springboot-app-ingress: java-springboot.example.com

OpenShift Routes:
 •  my-java-springboot-app-route: my-java-springboot-app-default.apps.ci-ln-8zbptfk-72292.origin-ci-int-gce.dev.rhcloud.com

Note that we can have a list of hosts for the same ingress or route. So the human-readable output could be a comma-separated list of hosts.

Example JSON output:

{
--- Other fields omitted for brevity ---

        "runningIn": ["Dev", "Deploy"],
        "ingresses": [
            {
               "name": "my-java-springboot-app-ingress",
               "hosts": [
                    "java-springboot.example.com"
                ]
            }
         ],
        "routes": [
            {
               "name": "my-java-springboot-app-route",
               "hosts": [
                   "my-java-springboot-app-default.apps.ci-ln-8zbptfk-72292.origin-ci-int-gce.dev.rhcloud.com"
               ]
            }
         ],
        "managedBy": "odo"
}

Notes

The Devfile might define Custom Resources (CRs) that would translate into Ingresses or Routes once deployed with odo deploy. From the odo side, there is no way to know whether a CR would create Ingresses or Routes later. This is fine for now; we limit the scope of this issue to Ingresses / Routes explicitly defined in the Devfile.

Links

/kind user-story

@openshift-ci openshift-ci bot added kind/user-story An issue of user-story kind triage/needs-information Indicates an issue needs more information in order to work on it. labels Jul 29, 2022
@cdrage
Copy link
Member

cdrage commented Aug 4, 2022

Needs more information.

Possibly use odo describe ?

@cdrage cdrage added the estimated-size/XS (1-5) Rough sizing for Epics. Less than one sprint of work for one person, but smaller than S. label Aug 4, 2022
@kadel kadel added the priority/Medium Nice to have issue. Getting it done before priority changes would be great. label Aug 8, 2022
@rm3l rm3l changed the title list Routes/Ingresses deployed by odo deploy List Routes/Ingresses deployed by odo deploy Aug 8, 2022
@rm3l rm3l changed the title List Routes/Ingresses deployed by odo deploy odo describe component: List Routes/Ingresses deployed by odo deploy Aug 8, 2022
@rm3l rm3l removed the triage/needs-information Indicates an issue needs more information in order to work on it. label Aug 8, 2022
@rm3l rm3l added this to odo v3.0.0 Aug 29, 2022
@rm3l rm3l removed this from odo v3-beta2 Aug 29, 2022
@rm3l rm3l added this to the v3.1.0 🚀 milestone Sep 30, 2022
@rm3l rm3l added this to odo Project Sep 30, 2022
@rm3l rm3l modified the milestones: v3.1.0 🚀, v3.2.0 🚀 Oct 12, 2022
@valaparthvi valaparthvi self-assigned this Oct 12, 2022
@valaparthvi
Copy link
Contributor

valaparthvi commented Oct 17, 2022

@kadel

  1. Should this have a different behavior for when Devfile is accessible and inaccessible?
  2. Should this also take into account OpenShift Ingresses?

@kadel
Copy link
Member Author

kadel commented Oct 17, 2022

  • Should this have a different behavior for when Devfile is accessible and inaccessible?

Yes. This information doesn't require any information from the devfile. Listing Routes and Ingressis should be done based on the information from the cluster.

  • Should this also take into account OpenShift Ingresses?

yes, by default, it should look for Ingress and Route

@valaparthvi valaparthvi moved this to In Progress 🚧 in odo Project Oct 19, 2022
@valaparthvi valaparthvi moved this from In Progress 🚧 to In Review 👀 in odo Project Oct 26, 2022
@rm3l rm3l modified the milestones: v3.2.0 🚀, v3.3.0 🚀 Oct 28, 2022
Repository owner moved this from In Review 👀 to Done ✅ in odo Project Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
estimated-size/XS (1-5) Rough sizing for Epics. Less than one sprint of work for one person, but smaller than S. kind/user-story An issue of user-story kind priority/Medium Nice to have issue. Getting it done before priority changes would be great.
Projects
Archived in project
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants