Implement "odo list" #6043
Implement "odo list" #6043
Conversation
openshift-ci
bot
added
do-not-merge/work-in-progress
✅ Deploy Preview for odo-docusaurus-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
feloy
force-pushed
the
feature-5991/list-all
branch
from
df200e6 to
de50759
Compare
feloy
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
feloy
force-pushed
the
feature-5991/list-all
branch
from
de50759 to
f03bcbe
Compare
| var localComponent api.ComponentAbstract | ||
| if devObj.Data != nil { | ||
| localComponent = api.ComponentAbstract{ | ||
| Name: devObj.Data.GetMetadata().Name, | ||
| ManagedBy: "", | ||
| RunningIn: []api.RunningMode{}, | ||
| Type: GetComponentTypeFromDevfileMetadata(devObj.Data.GetMetadata()), | ||
| } | ||
| } | ||
|
|
||
| componentInDevfile := "" | ||
| if localComponent.Name != "" { | ||
| if !Contains(localComponent, devfileComponents) { | ||
| devfileComponents = append(devfileComponents, localComponent) | ||
| } | ||
| componentInDevfile = localComponent.Name | ||
| } |
There was a problem hiding this comment.
Do we want to print the local component/binding if --namespace is passed? I find it a little confusing to display the binding/component running in some other namespace to be displayed when I explicitly ask for some other namespace.
➜ 102 odo list binding --namespace operators
✓ Listing ServiceBindings from the namespace "operators" [3ms]
NAME APPLICATION SERVICES RUNNING IN
* my-nodejs-app-cluster-sample my-nodejs-app-app (Deployment) cluster-sample (Cluster.postgresql.k8s.enterprisedb.io) None
➜ 102 odo list binding
✓ Listing ServiceBindings from the namespace "default" [9ms]
NAME APPLICATION SERVICES RUNNING IN
* my-nodejs-app-cluster-sample my-nodejs-app-app (Deployment) cluster-sample (Cluster.postgresql.k8s.enterprisedb.io) None There was a problem hiding this comment.
@kadel what's your opinion?
There was a problem hiding this comment.
If we decide to, I would prefer to make this change as part as another PR
There was a problem hiding this comment.
I agree it seems a bit confusing to display the local component/binding when requesting some other namespace (especially since the first line printed is Listing {ServiceBindings,resources} from the namespace "$ns").
But as discussed, it is okay to change this in a separate PR.
feloy
requested review from
rm3l and
valaparthvi
and removed request for
dharmit
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rm3l The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-robot
added
the
needs-rebase
Co-authored-by: Armel Soro <[email protected]>
feloy
force-pushed
the
feature-5991/list-all
branch
from
2e365c6 to
7315268
Compare
openshift-merge-robot
removed
the
needs-rebase
Thanks for your review @rm3l I approved the docs changes and rebased on master to fix the conflicts. |
openshift-ci
bot
added
the
lgtm
|
SonarCloud Quality Gate failed.
|
|
/override ci/prow/v4.10-integration-e2e /override SonarCloud Code Analysis |
|
@feloy: Overrode contexts on behalf of feloy: SonarCloud Code Analysis, ci/prow/v4.10-integration-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* Move "odo list" to "odo list component" * Refactor odo list component * Add --namespace flag to "odo list binding" * odo list implementation * Doc * Apply suggestions from code review Co-authored-by: Armel Soro <[email protected]> Co-authored-by: Armel Soro <[email protected]>
What type of PR is this:
/kind feature
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #5991
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: