Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odo list should be combined output of odo list component and odo list binding #5991

Closed
6 tasks
kadel opened this issue Jul 29, 2022 · 3 comments · Fixed by #6043
Closed
6 tasks

odo list should be combined output of odo list component and odo list binding #5991

kadel opened this issue Jul 29, 2022 · 3 comments · Fixed by #6043
Assignees
Labels
estimated-size/S (5-10) Rough sizing for Epics. Less then one sprint of work for one person kind/user-story An issue of user-story kind priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).

Comments

@kadel
Copy link
Member

kadel commented Jul 29, 2022

/kind user-story

User Story

As an odo user, I want to be able to list all things that are related to my application.

Acceptance Criteria

  • odo list * without --namespace flag should list resources from the current namespace, if --namespace is specified it should use that namespace instead
  • odo list should list components, bindings, (no namespaces) in one screen
  • odo list components should list just components
  • odo list binding should list just components
  • odo list namespace should list just components
  • json output for combined and filtered commands

examples:

▶ odo list
 ✓  Listing from namespace 'asdf' [269ms]

Components:
 NAME                      PROJECT TYPE  RUNNING IN  MANAGED
 * my-java-springboot-app  spring        None        odo

ServiceBindings:
 NAME         APPLICATION                              SERVICES                                                   RUNNING IN
 * app-hippo  my-java-springboot-app-app (Deployment)  hippo (PostgresCluster.postgres-operator.crunchydata.com)  None


▶ odo list binding
 ✓  Listing ServiceBindings from the namespace "asdf" [51ms]
 NAME         APPLICATION                              SERVICES                                                   RUNNING IN
 * app-hippo  my-java-springboot-app-app (Deployment)  hippo (PostgresCluster.postgres-operator.crunchydata.com)  None


▶ odo list components
 ✓  Listing components from namespace 'asdf' [269ms]
 NAME                      PROJECT TYPE  RUNNING IN  MANAGED
 * my-java-springboot-app  spring        None        odo


▶ odo list namespace
ACTIVE     NAME
*          asdf

/kind user-story

@openshift-ci openshift-ci bot added the kind/user-story An issue of user-story kind label Jul 29, 2022
@kadel kadel added priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). and removed kind/user-story An issue of user-story kind labels Jul 29, 2022
@kadel kadel added the kind/user-story An issue of user-story kind label Jul 29, 2022
@cdrage cdrage added the estimated-size/S (5-10) Rough sizing for Epics. Less then one sprint of work for one person label Aug 4, 2022
@kadel kadel mentioned this issue Aug 10, 2022
2 tasks
@feloy feloy mentioned this issue Aug 22, 2022
3 tasks
@feloy
Copy link
Contributor

feloy commented Aug 22, 2022

@kadel Do we want a --namespace flag for odo list ?

For the moment, odo list component --namespace (previously odo list --namespace) has this flag, but odo list binding does not have this flag.

If we add it to odo list, do we also add it to odo list binding?

@kadel
Copy link
Member Author

kadel commented Aug 23, 2022

@kadel Do we want a --namespace flag for odo list ?

yes, it should be there, and all the subcommands should have it as well. It looks like we forgot about --namespace when defining odo list binding :-(

@feloy feloy moved this to For review in odo v3-beta2 Aug 23, 2022
@valaparthvi
Copy link
Contributor

valaparthvi commented Aug 24, 2022

@kadel Do we want a --namespace flag for odo list ?

yes, it should be there, and all the subcommands should have it as well. It looks like we forgot about --namespace when defining odo list binding :-(

@feloy do you intend on addressing this in your PR #6043?

I see you have addressed it.

Repository owner moved this from For review to Done in odo v3-beta2 Aug 29, 2022
@rm3l rm3l added the v3 label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
estimated-size/S (5-10) Rough sizing for Epics. Less then one sprint of work for one person kind/user-story An issue of user-story kind priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants