[#5330] Make odo build-images return an error if no Image component found in Devfile
#5608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
rm3l
force-pushed
the
5330-build-images-fails-silently-if-no-images-found
branch
from
973b3d9 to
03bfa2c
Compare
As reported in redhat-developer#5330, this makes more sense rather than exiting silently.
rm3l
force-pushed
the
5330-build-images-fails-silently-if-no-images-found
branch
from
03bfa2c to
de29eb3
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
valaparthvi
approved these changes
Mar 30, 2022
openshift-ci
bot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: valaparthvi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@rm3l Feel free to override prow test if it fails. IBM tests pass, so we're good to go. |
cdrage
pushed a commit
to cdrage/odo
that referenced
this pull request
Aug 31, 2022
… Image component found in Devfile (redhat-developer#5608) * Add test highlighting the issue * Make `odo build-images` return an error if no Image component found As reported in redhat-developer#5330, this makes more sense rather than exiting silently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind bug
What does this PR do / why we need it:
See #5330 for more context.
Which issue(s) this PR fixes:
Fixes #5330
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
When running
odo build-imageswith a Devfile that has noImagecomponent in it, the command should not succeed and should output an error message on the standard error instead, like so: