Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-images fails silently if no images found #5330

Closed
gorkem opened this issue Jan 11, 2022 · 0 comments · Fixed by #5608
Closed

build-images fails silently if no images found #5330

gorkem opened this issue Jan 11, 2022 · 0 comments · Fixed by #5608
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@gorkem
Copy link
Contributor

gorkem commented Jan 11, 2022

/kind bug

What versions of software are you using?

Operating System:
MacOS

Output of odo version:
odo v2.4.3 (16dd43c)

How did you run odo exactly?

odo build-images

Actual behavior

When there are no image components exist in a devfile build-images fail silently.

Expected behavior

A message that explains the command has not done anything because it could not find suitable component types. In this case Image.

Any logs, error output, etc?

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 11, 2022
rm3l added a commit to rm3l/odo that referenced this issue Mar 30, 2022
As reported in redhat-developer#5330, this makes more sense rather than exiting silently.
@rm3l rm3l moved this to For Review in odo v3-alpha1 Mar 30, 2022
@rm3l rm3l self-assigned this Mar 30, 2022
rm3l added a commit to rm3l/odo that referenced this issue Mar 30, 2022
As reported in redhat-developer#5330, this makes more sense rather than exiting silently.
rm3l added a commit to rm3l/odo that referenced this issue Mar 30, 2022
As reported in redhat-developer#5330, this makes more sense rather than exiting silently.
openshift-merge-robot pushed a commit that referenced this issue Mar 30, 2022
… found in Devfile (#5608)

* Add test highlighting the issue

* Make `odo build-images` return an error if no Image component found

As reported in #5330, this makes more sense rather than exiting silently.
Repository owner moved this from For Review to Done in odo v3-alpha1 Mar 30, 2022
cdrage pushed a commit to cdrage/odo that referenced this issue Aug 31, 2022
… Image component found in Devfile (redhat-developer#5608)

* Add test highlighting the issue

* Make `odo build-images` return an error if no Image component found

As reported in redhat-developer#5330, this makes more sense rather than exiting silently.
@rm3l rm3l added the v3 label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
No open projects
Status: Done
2 participants