Fix odo log flake #3733

adisky · 2020-08-11T07:44:35Z

What type of PR is this?

/kind flake

What does does this PR do / why we need it:
Fixes the flag for odo log -f test. This PR updates the test to check the log until expected log is printed and timeout if it doesn't gets logged in specified timeout duration.

Which issue(s) this PR fixes:

Fixes #3610

PR acceptance criteria:

Unit test
Integration test
Documentation

How to test changes / Special notes to the reviewer:

amitkrout · 2020-08-11T08:42:07Z

tests/helper/helper_generic.go

+// It is different from WaitforCmdOut which gives stdout in one go using session.Out.Contents()
+// for commands like odo log -f which streams continuous data and does not terminate by their own
+// we need to read the stream data from buffer.
+func RunCmdWithMatchOutputFromBuffer(timeoutAfter time.Duration, matchString, program string, args ...string) (bool, error) {


prietyc123 · 2020-08-11T10:14:49Z

tests/integration/devfile/cmd_devfile_log_test.go

-			output = helper.CmdShouldRunWithTimeout(1*time.Second, "odo", "log", "-f")
-			Expect(output).To(ContainSubstring("program=devrun"))
+			// Test odo log -f
+			match, err := helper.RunCmdWithMatchOutputFromBuffer(30*time.Second, "program=devrun", "odo", "log", "-f")


prietyc123 · 2020-08-11T10:30:33Z

tests/helper/helper_generic.go

+// It is different from WaitforCmdOut which gives stdout in one go using session.Out.Contents()
+// for commands like odo log -f which streams continuous data and does not terminate by their own
+// we need to read the stream data from buffer.
+func RunCmdWithMatchOutputFromBuffer(timeoutAfter time.Duration, matchString, program string, args ...string) (bool, error) {


I was thinking instead of overloading helper file, Can't we use gingko in-build pattern for timeout - https://onsi.github.io/ginkgo/#asynchronous-tests

@prietyc123 I follow the pattern from odo watch tests, timeout we are using this way only. I agree with your concern, once you update some other tests with gingko in-build pattern as an example, i would follow the same.

codecov · 2020-08-11T10:59:12Z

Codecov Report

Merging #3733 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3733   +/-   ##
=======================================
  Coverage   44.93%   44.93%           
=======================================
  Files         133      133           
  Lines       12749    12749           
=======================================
  Hits         5729     5729           
  Misses       6460     6460           
  Partials      560      560

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf474b1...a0daeb1. Read the comment docs.

mik-dass · 2020-08-11T11:54:49Z

tests/helper/helper_generic.go

+
+	command := exec.Command(program, args...)
+	command.Stdout = &buf
+


I think we should also check the StdErr stream. In case of the timeout, we can print the contents from the error buffer. It will help in debugging in case the command fails to stream.

I think it's better to use a different buffer for the error stream like in case of the watch test.

tests/helper/helper_generic.go

`

mik-dass · 2020-08-12T05:54:35Z


• Failure [342.243 seconds]
odo devfile watch command tests
/go/src/github.com/openshift/odo/tests/integration/devfile/cmd_devfile_watch_test.go:15
  when executing odo watch after odo push with debug flag
  /go/src/github.com/openshift/odo/tests/integration/devfile/cmd_devfile_watch_test.go:124
    should be able to start a debug session after push with debug flag using odo watch and revert back after normal push [It]
    /go/src/github.com/openshift/odo/tests/integration/devfile/cmd_devfile_watch_test.go:125
    Timeout after 5.00 minutes

/retest

amitkrout · 2020-08-13T10:41:43Z

/lgtm

cdrage

small nitpick but code looks good to to me.

/approve

cdrage · 2020-08-17T18:56:15Z

tests/helper/helper_generic.go

+		select {
+		case <-timeoutCh:
+			fmt.Fprintln(GinkgoWriter, errBuf.String())
+			return false, errors.New("Timeout waiting for the conditon")


no capitalization on errors

openshift-ci-robot · 2020-08-17T18:57:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~tests/OWNERS~~ [cdrage]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

adisky · 2020-08-18T08:22:24Z

/retest

odo devfile watch command tests
/go/src/github.com/openshift/odo/tests/integration/devfile/cmd_devfile_watch_test.go:20
  when executing odo watch after odo push with debug flag
  /go/src/github.com/openshift/odo/tests/integration/devfile/cmd_devfile_watch_test.go:185
    should be able to start a debug session after push with debug flag using odo watch and revert back after normal push
    /go/src/github.com/openshift/odo/tests/integration/devfile/cmd_devfile_watch_test.go:186
------------------------------
•••••••••••••••••••••••••••••••••••••••••••••••••
	 -------------------------------------------------------------------
	|                                                                   |
	|  Ginkgo timed out waiting for all parallel nodes to report back!  |
	|                                                                   |
	 -------------------------------------------------------------------
 devfile timed out. path: ./tests/integration/devfile

openshift-bot · 2020-08-18T08:25:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-08-18T12:32:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot added the flake Categorizes issue or PR as related to a flaky test. label Aug 11, 2020

openshift-ci-robot requested review from cdrage and dharmit August 11, 2020 07:44

Fix odo log flake

29d8c28

adisky force-pushed the fix-odo-log-test branch from 2e1bb20 to 29d8c28 Compare August 11, 2020 07:48

fix some spells

486c218

amitkrout reviewed Aug 11, 2020

View reviewed changes

prietyc123 reviewed Aug 11, 2020

View reviewed changes

prietyc123 suggested changes Aug 11, 2020

View reviewed changes

openshift-ci-robot assigned prietyc123 Aug 11, 2020

mik-dass reviewed Aug 11, 2020

View reviewed changes

tests/helper/helper_generic.go Show resolved Hide resolved

Aditi Sharma added 2 commits August 11, 2020 17:50

pass Stderr stream to buffer as well

97f60c5

`

Use seperate buffer for stderr

a0daeb1

amitkrout mentioned this pull request Aug 11, 2020

odo watch try to remove non-existent file #3736

Closed

openshift-ci-robot assigned amitkrout Aug 13, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 13, 2020

cdrage approved these changes Aug 17, 2020

View reviewed changes

openshift-ci-robot assigned cdrage Aug 17, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Aug 17, 2020

openshift-merge-robot merged commit eec93d3 into redhat-developer:master Aug 18, 2020

kadel mentioned this pull request Aug 21, 2020

Ginkgo parallel test node CI timeout debugging #3792

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix odo log flake #3733

Fix odo log flake #3733

adisky commented Aug 11, 2020 •

edited

Loading

amitkrout Aug 11, 2020

prietyc123 Aug 11, 2020

prietyc123 Aug 11, 2020 •

edited

Loading

adisky Aug 11, 2020

codecov bot commented Aug 11, 2020 •

edited

Loading

mik-dass Aug 11, 2020

adisky Aug 11, 2020

mik-dass Aug 11, 2020

adisky Aug 11, 2020

mik-dass commented Aug 12, 2020

amitkrout commented Aug 13, 2020

cdrage left a comment

cdrage Aug 17, 2020

openshift-ci-robot commented Aug 17, 2020

adisky commented Aug 18, 2020

openshift-bot commented Aug 18, 2020

openshift-bot commented Aug 18, 2020


		command := exec.Command(program, args...)
		command.Stdout = &buf

Fix odo log flake #3733

Fix odo log flake #3733

Conversation

adisky commented Aug 11, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prietyc123 Aug 11, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Aug 11, 2020 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mik-dass commented Aug 12, 2020

amitkrout commented Aug 13, 2020

cdrage left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openshift-ci-robot commented Aug 17, 2020

adisky commented Aug 18, 2020

openshift-bot commented Aug 18, 2020

openshift-bot commented Aug 18, 2020

adisky commented Aug 11, 2020 •

edited

Loading

prietyc123 Aug 11, 2020 •

edited

Loading

codecov bot commented Aug 11, 2020 •

edited

Loading