Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odo log -f terminates earlier #3610

Closed
amitkrout opened this issue Jul 21, 2020 · 6 comments · Fixed by #3733
Closed

odo log -f terminates earlier #3610

amitkrout opened this issue Jul 21, 2020 · 6 comments · Fixed by #3733
Assignees
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering flake Categorizes issue or PR as related to a flaky test. kind/bug Categorizes issue or PR as related to a bug.

Comments

@amitkrout
Copy link
Contributor

/kind bug
/kind flake

What versions of software are you using?

Operating System:
supported
Output of odo version:
master

How did you run odo exactly?

This is hit in the CI. You can also reproduce it locally by running the spec (keep trying until you reproduce it)

Spec : https://github.com/openshift/odo/blob/master/tests/integration/devfile/cmd_devfile_log_test.go#L51

CI failure at line : https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_odo/3601/pull-ci-openshift-odo-master-v4.2-integration-e2e/1285441618282811392#1:build-log.txt%3A94332

Actual behavior

 Running odo with args [odo log -f]
[odo] I0721 07:11:31.820487    6939 preference.go:196] The path for preference file is /tmp/187530165/config.yaml
[odo] I0721 07:11:31.820763    6939 preference.go:196] The path for preference file is /tmp/187530165/config.yaml 

Expected behavior

program=devrun should be listed in the log output

Any logs, error output, etc?

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_odo/3601/pull-ci-openshift-odo-master-v4.2-integration-e2e/1285441618282811392#1:build-log.txt%3A94345

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. flake Categorizes issue or PR as related to a flaky test. labels Jul 21, 2020
@amitkrout amitkrout added area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering kind/failing-test labels Jul 21, 2020
@girishramnani
Copy link
Contributor

the one approach that will work here is to increase the timeout - maybe 5s to be safe?

@girishramnani
Copy link
Contributor

we could do something super intelligent like check between each 0.5s that the buffer size of the command has increased or not, if it hasn't that means the odo log -f has reached the end but I mean for what gain? 2-3s?

@amitkrout
Copy link
Contributor Author

Refer - #3613 (comment)

@kadel
Copy link
Member

kadel commented Aug 7, 2020

/assign

@amitkrout
Copy link
Contributor Author

Latest update - #3613 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering flake Categorizes issue or PR as related to a flaky test. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
5 participants