Skip to content

Commit

Permalink
fix: remove unused argument which is triggering in lint (needed for P…
Browse files Browse the repository at this point in the history
…Rs to pass CI) (argoproj#9186)

* fix: remove unused argument which was triggering in lint

Signed-off-by: Julie Vogelman <[email protected]>

* fix: references calling method

Signed-off-by: Julie Vogelman <[email protected]>
Signed-off-by: Reddy <[email protected]>
  • Loading branch information
juliev0 authored and Reddy committed Jan 2, 2023
1 parent 17b463a commit 8a2d3f7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions workflow/controller/exec_control.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package controller

import (
"context"
"fmt"
"sync"
"time"
Expand All @@ -15,7 +14,7 @@ import (

// applyExecutionControl will ensure a pod's execution control annotation is up-to-date
// kills any pending and running pods when workflow has reached it's deadline
func (woc *wfOperationCtx) applyExecutionControl(ctx context.Context, pod *apiv1.Pod, wfNodesLock *sync.RWMutex) {
func (woc *wfOperationCtx) applyExecutionControl(pod *apiv1.Pod, wfNodesLock *sync.RWMutex) {
if pod == nil {
return
}
Expand Down
2 changes: 1 addition & 1 deletion workflow/controller/operator.go
Original file line number Diff line number Diff line change
Expand Up @@ -1020,7 +1020,7 @@ func (woc *wfOperationCtx) podReconciliation(ctx context.Context) error {
go func(pod *apiv1.Pod) {
defer wg.Done()
performAssessment(pod)
woc.applyExecutionControl(ctx, pod, wfNodesLock)
woc.applyExecutionControl(pod, wfNodesLock)
<-parallelPodNum
}(pod)
}
Expand Down

0 comments on commit 8a2d3f7

Please sign in to comment.