fix: remove unused argument which is triggering in lint (needed for PRs to pass CI) #9186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julie Vogelman <[email protected]>
Signed-off-by: Julie Vogelman <[email protected]>
sarabala1979
approved these changes
Jul 20, 2022
Signed-off-by: Julie Vogelman <[email protected]>
Signed-off-by: Julie Vogelman <[email protected]>
Signed-off-by: Julie Vogelman <[email protected]>
Closed
reddymh
pushed a commit
to reddymh/argo-workflows
that referenced
this pull request
Jan 2, 2023
…Rs to pass CI) (argoproj#9186) * fix: remove unused argument which was triggering in lint Signed-off-by: Julie Vogelman <[email protected]> * fix: references calling method Signed-off-by: Julie Vogelman <[email protected]> Signed-off-by: Reddy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golangcli-lint recently went from version 1.47.0 to 1.47.1. I think that must be why we're all of a sudden seeing this error:
Error: workflow/controller/exec_control.go:18:50: (*wfOperationCtx).applyExecutionControl - ctx is unused (unparam)as here: https://github.com/argoproj/argo-workflows/runs/7419737341?check_suite_focus=true