Skip to content

[rhoai-3.4-ea.2] fix: add rhoai-version param to PR pipeline definitions#2054

Merged
jiridanek merged 1 commit intored-hat-data-services:rhoai-3.4-ea.2from
jiridanek:jdanek/rhoai-3.4-ea.2-fix-pr-pipeline-rhoai-version
Mar 26, 2026
Merged

[rhoai-3.4-ea.2] fix: add rhoai-version param to PR pipeline definitions#2054
jiridanek merged 1 commit intored-hat-data-services:rhoai-3.4-ea.2from
jiridanek:jdanek/rhoai-3.4-ea.2-fix-pr-pipeline-rhoai-version

Conversation

@jiridanek
Copy link
Copy Markdown
Member

@jiridanek jiridanek commented Mar 26, 2026

Summary

  • Add missing rhoai-version: "3.4.0-ea.2" parameter to all 16 pull-request pipeline definitions
  • Fixes Konflux PR build startup error: ERROR: RHOAI version is required but was not provided
  • The push pipelines already had this param; the PR pipelines were missing it

Test plan

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated build pipeline configurations to reference version 3.4.0-ea.2 across runtime and workbench container build processes.

@openshift-ci openshift-ci Bot requested review from ayush17 and dibryant March 26, 2026 18:01
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 26, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign daniellutz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 26, 2026

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning PR description provides a clear summary and fix rationale, but lacks detailed testing information and self-checklist completion required by the template. Complete the self-checklist items (confirm make test was run and testing details), add detailed testing instructions explaining how Konflux PR builds will be verified, and mark/complete all merge criteria checkboxes.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed Title uses imperative mood 'add', includes release tag reference [rhoai-3.4-ea.2], follows preferred format with scope (fix:), and accurately describes the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Branch Prefix Policy ✅ Passed PR title correctly starts with '[rhoai-3.4-ea.2] ' matching the target branch name as required by policy.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

The konflux-central pipeline now requires the rhoai-version parameter.
PR builds were failing with:
  ERROR: RHOAI version is required but was not provided

Add rhoai-version: "3.4.0-ea.2" to all 16 pull-request pipeline files,
matching the value already set in the push pipeline definitions.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jiridanek jiridanek force-pushed the jdanek/rhoai-3.4-ea.2-fix-pr-pipeline-rhoai-version branch from 6d9f6bc to 188240d Compare March 26, 2026 18:02
@jiridanek
Copy link
Copy Markdown
Member Author

/build-konflux

@jiridanek jiridanek merged commit aa79fa2 into red-hat-data-services:rhoai-3.4-ea.2 Mar 26, 2026
27 of 47 checks passed
@jiridanek jiridanek deleted the jdanek/rhoai-3.4-ea.2-fix-pr-pipeline-rhoai-version branch March 26, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant