[rhoai-3.4-ea.2] lockfile refresh with protobuf pinned to keep IBM arch wheels#2053
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…E=1 gmake refresh-lock-files needed to get fixed build of pyarrow for the No module named 'pyarrow._s3fs' crash
…c64le/s390x wheels protobuf 6.33.6 dropped ppc64le and s390x wheels from the internal PyPI index, which would break builds for jupyter-minimal, jupyter-datascience, runtime-minimal, and runtime-datascience on those architectures. Revert protobuf 6.33.6→6.33.5 and 7.34.1→7.34.0 to restore the IBM architecture wheels while keeping all other package upgrades from the lockfile refresh. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
33139b2 to
7e8a234
Compare
|
/build-konflux |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
jupyter/rocm/tensorflow/ubi9-python-3.12/pylock.toml (1)
2-2:⚠️ Potential issue | 🟡 MinorUse the repository’s lock refresh target for regeneration.
The lock header indicates direct
uv pip compileinvocation at Line 2. Please regenerate via the repo-standard target to match contributor workflow and avoid drift in future refreshes.As per coding guidelines: "Use
pyproject.tomlandpylock.tomlfor Python dependencies; regenerate lock files after dependency changes by runningmake refresh-pipfilelock-files".🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@jupyter/rocm/tensorflow/ubi9-python-3.12/pylock.toml` at line 2, Replace the direct "uv pip compile ..." header line in pylock.toml with a note that the lockfile is generated via the repository target; regenerate the lock by running the standard target "make refresh-pipfilelock-files" instead of invoking the uv pip compile command directly, and commit the updated pylock.toml so the header and contents reflect the repo-standard regeneration workflow.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@jupyter/rocm/tensorflow/ubi9-python-3.12/pylock.toml`:
- Line 2: Replace the direct "uv pip compile ..." header line in pylock.toml
with a note that the lockfile is generated via the repository target; regenerate
the lock by running the standard target "make refresh-pipfilelock-files" instead
of invoking the uv pip compile command directly, and commit the updated
pylock.toml so the header and contents reflect the repo-standard regeneration
workflow.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 0056d5f2-e4b6-4383-9f24-6cb0662ac49f
📒 Files selected for processing (18)
codeserver/ubi9-python-3.12/uv.lock.d/pylock.cpu.tomljupyter/datascience/ubi9-python-3.12/uv.lock.d/pylock.cpu.tomljupyter/minimal/ubi9-python-3.12/uv.lock.d/pylock.cpu.tomljupyter/minimal/ubi9-python-3.12/uv.lock.d/pylock.cuda.tomljupyter/minimal/ubi9-python-3.12/uv.lock.d/pylock.rocm.tomljupyter/pytorch+llmcompressor/ubi9-python-3.12/uv.lock.d/pylock.cuda.tomljupyter/pytorch/ubi9-python-3.12/uv.lock.d/pylock.cuda.tomljupyter/rocm/pytorch/ubi9-python-3.12/uv.lock.d/pylock.rocm.tomljupyter/rocm/tensorflow/ubi9-python-3.12/pylock.tomljupyter/tensorflow/ubi9-python-3.12/uv.lock.d/pylock.cuda.tomljupyter/trustyai/ubi9-python-3.12/uv.lock.d/pylock.cpu.tomlruntimes/datascience/ubi9-python-3.12/uv.lock.d/pylock.cpu.tomlruntimes/minimal/ubi9-python-3.12/uv.lock.d/pylock.cpu.tomlruntimes/pytorch+llmcompressor/ubi9-python-3.12/uv.lock.d/pylock.cuda.tomlruntimes/pytorch/ubi9-python-3.12/uv.lock.d/pylock.cuda.tomlruntimes/rocm-pytorch/ubi9-python-3.12/uv.lock.d/pylock.rocm.tomlruntimes/rocm-tensorflow/ubi9-python-3.12/pylock.tomlruntimes/tensorflow/ubi9-python-3.12/uv.lock.d/pylock.cuda.toml
e87b2c7
into
red-hat-data-services:rhoai-3.4-ea.2
https://redhat.atlassian.net/browse/RHAIENG-3611
Summary
FORCE_LOCKFILES_UPGRADE=1 gmake refresh-lock-filesto update all pylock files (same as [rhoai-3.4-ea.2] run FORCE_LOCKFILES_UPGRADE=1 gmake refresh-lock-files #2052)ppc64leands390xwheels from the internal PyPI indexjupyter-minimal-ubi9-python-3.12(ppc64le, s390x)jupyter-datascience-ubi9-python-3.12(ppc64le)runtime-minimal-ubi9-python-3.12(s390x)runtime-datascience-ubi9-python-3.12(s390x)Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit