-
-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Downgrade 8.0] Union Type downgrade on anonymous functions #5989
Comments
Go for it 👍 |
@TomasVotruba I offered to do it 1 month ago, when I had a window of time. Now I'm pretty busy. So please wait some 45 days, when I finish my deadline. Otherwise, your team can also do it (this one will take you guys like 3 min to do). Same with #5961. Also, I just found out that the $foo = array_filter(
$list,
// This needs be removed for PHP 7.1, currently it is not
function (mixed $fieldArgValue) {
return is_null($fieldArgValue);
}
); And maybe there are other things in anonymous functions that need be downgraded? |
For a bugfix just send PR next time, no need to create issues that stale ;) |
Closing as we don't use union types in downgraded Rector yet. Feel free to contribute 👍 |
rectorphp/rector-src@8a7cd36 [Renaming] Use continue 2 on RenameMethodRector after ClassMethod renamed on configured method call renames loop (#5989)
Feature Request
DowngradeUnionTypeDeclarationRector
is currently not handling anonymous functions, so it must be completed.I can work on it.
Diff
The text was updated successfully, but these errors were encountered: