Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DowngradePhp70] Handle DowngradeScalarTypeDeclarationRector on Closure #102

Merged
merged 1 commit into from
May 25, 2021
Merged

[DowngradePhp70] Handle DowngradeScalarTypeDeclarationRector on Closure #102

merged 1 commit into from
May 25, 2021

Conversation

samsonasik
Copy link
Member

@samsonasik
Copy link
Member Author

/cc @JoosuaKoskinen

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit 4da81fa into main May 25, 2021
@TomasVotruba TomasVotruba deleted the fix-6451 branch May 25, 2021 16:28
@TomasVotruba
Copy link
Member

Thanks 👍

@leoloso
Copy link
Contributor

leoloso commented May 25, 2021

@samsonasik The same issue also happens with union types and mixed: rectorphp/rector#5989

Would you like to handle it also? Should I reopen that bug report?

@samsonasik
Copy link
Member Author

@leoloso I created PR #105 for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return type not removed from anonymous function on downgrade
3 participants
@samsonasik @TomasVotruba @leoloso