Staging to main: Merge multiple Dockerfiles into a single one #2189
Conversation
Merge multiple Dockerfiles into a single one --------- Signed-off-by: Simon Zhao <[email protected]> Co-authored-by: Miguel Fierro <[email protected]>
miguelgfierro
requested review from
gramhagen,
anargyri,
loomlike,
wutaomsft and
SimonYansenZhao
as code owners
|
I checked and the GPU tests that were failing now are working: https://github.com/recommenders-team/recommenders/actions/runs/11831613396 |
| // https://github.com/devcontainers/features/blob/main/src/anaconda/devcontainer-feature.json | ||
| "ghcr.io/devcontainers/features/anaconda:1": { | ||
| "version": "2024.06-1" | ||
| "build": { |
There was a problem hiding this comment.
Some of the GPU tests failed. When looking at the AzureML workspace I see this error: Provisioning error
The specified Virtual Machine size in low priority is currently out of capacity. Please retry later, try reducing the Virtual Machine size or number of instances, try using dedicated VMs to improve chances of capacity allocations, or try deploying to a different region.
I'll try to run the tests again, otherwise, I'll try to see if we need new VMs.
There was a problem hiding this comment.
I find the VM size is specified in tests/ci/azureml_tests/submit_groupwise_azureml_pytest.py. Maybe we need to use another one, because the code was written almost 3 years ago.
There was a problem hiding this comment.
The VMs are chosen from the portal. Finally it worked. I think it was a momentary error.
Merging.
There was a problem hiding this comment.
@SimonYansenZhao the process automatically cancells after 6h. I was trying to find how this limit is defined to reduce it, but I don't know where we are setting this value. Do you know?
There was a problem hiding this comment.
Just found this: https://stackoverflow.com/a/59076067, and https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes says the default timeout is 360mins.
Staging to main: Merge multiple Dockerfiles into a single one
Merge multiple Dockerfiles into a single one
Signed-off-by: Simon Zhao [email protected]
Co-authored-by: Miguel Fierro [email protected]
Description
Related Issues
References
Checklist:
git commit -s -m "your commit message".staging branchAND NOT TOmain branch.