Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge multiple Dockerfiles into a single one #2167

Merged
merged 38 commits into from
Nov 14, 2024
Merged

Conversation

SimonYansenZhao
Copy link
Collaborator

Description

This PR merges the following multiple uses of Dockerfile into a single place in tools/docker/Dockerfile for easier maintainance in the future:

Related Issues

None

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • I have signed the commits, e.g. git commit -s -m "your commit message".
  • This PR is being made to staging branch AND NOT TO main branch.

Signed-off-by: Simon Zhao <[email protected]>
Signed-off-by: Simon Zhao <[email protected]>
@miguelgfierro
Copy link
Collaborator

hi @SimonYansenZhao the tests should be working now after #2169

Signed-off-by: Simon Zhao <[email protected]>
Signed-off-by: Simon Zhao <[email protected]>
Signed-off-by: Simon Zhao <[email protected]>
Signed-off-by: Simon Zhao <[email protected]>
Signed-off-by: Simon Zhao <[email protected]>
Signed-off-by: Simon Zhao <[email protected]>
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.devcontainer/devcontainer.json Show resolved Hide resolved
tools/docker/Dockerfile Show resolved Hide resolved
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Fixed some minor typos

SETUP.md Outdated Show resolved Hide resolved
SETUP.md Outdated Show resolved Hide resolved
SETUP.md Outdated Show resolved Hide resolved
SETUP.md Outdated Show resolved Hide resolved
SETUP.md Outdated Show resolved Hide resolved
SETUP.md Outdated Show resolved Hide resolved
SETUP.md Outdated Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
SimonYansenZhao and others added 8 commits November 14, 2024 08:47
Co-authored-by: Miguel Fierro <[email protected]>
Co-authored-by: Miguel Fierro <[email protected]>
Co-authored-by: Miguel Fierro <[email protected]>
Co-authored-by: Miguel Fierro <[email protected]>
Co-authored-by: Miguel Fierro <[email protected]>
Co-authored-by: Miguel Fierro <[email protected]>
Co-authored-by: Miguel Fierro <[email protected]>
Co-authored-by: Miguel Fierro <[email protected]>
@SimonYansenZhao SimonYansenZhao merged commit f2abb55 into staging Nov 14, 2024
37 of 38 checks passed
@SimonYansenZhao SimonYansenZhao deleted the simonz/dockerfile branch November 14, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants