Remove require-package label support
#363
Conversation
|
Probably worth removing the label as well as part of this PR! It should probably have a mention in the changelog, maybe simply a ref to this PR in the |
Leonidas-from-XIV
changed the title
rulerequire-package label support
|
I've removed the label and added a changelog entry. I think it won't hurt to be specific about this in the changelog in case people wonder what happened to this label. |
|
To clarify this label was only consumed by |
| @@ -22,6 +22,8 @@ | |||
| is 4.08 to 4.13 now (#345, @Leonidas-from-XIV) | |||
| - Do not install deprecated `mdx` binary anymore (#274, @gpetiot) | |||
| - Remove deprecated `rule` command (#312, @gpetiot) | |||
| - Remove support for `require-package` label, use the `mdx` stanza in dune | |||
There was a problem hiding this comment.
Maybe mention here that it was only used by MDX rule and that it can otherwise be safely removed!
CHANGES: #### Added - Add trailing `;;` to the output of toplevel phrases that were missing it. (realworldocaml/mdx#346, @Leonidas-from-XIV) - Make MDX compatible with OCaml 4.14 (realworldocaml/mdx#356, @NathanReb) #### Fixed - Use the same output as the normal toplevel. Mdx used to carry an unsafe patch to work around a bug fixed in OCaml 4.06 and that patch would change the printed types in some corner cases. (realworldocaml/mdx#322, @emillon) #### Removed - Dropped compatibility with older OCaml versions. The minimal supported range is 4.08 to 4.13 now (realworldocaml/mdx#345, @Leonidas-from-XIV) - Do not install deprecated `mdx` binary anymore (realworldocaml/mdx#274, @gpetiot) - Remove deprecated `rule` command (realworldocaml/mdx#312, @gpetiot) - Remove support for `require-package` label, use the `mdx` stanza in dune instead. This label was only used for the `rule` command and can now be safely removed. (realworldocaml/mdx#363, @Leonidas-from-XIV)
This tests functionality that we don't support anymore since the way to do this is via the dune stanza.