Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not install deprecated mdx binary anymore #274

Merged
merged 1 commit into from
Sep 24, 2021
Merged

Do not install deprecated mdx binary anymore #274

merged 1 commit into from
Sep 24, 2021

Conversation

gpetiot
Copy link
Contributor

@gpetiot gpetiot commented Jun 18, 2020

No description provided.

@gpetiot gpetiot requested a review from NathanReb June 18, 2020 08:09
Copy link
Contributor

@NathanReb NathanReb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather hold this back until we reach 2.0.0 !

@gpetiot gpetiot marked this pull request as draft July 30, 2020 09:16
@gpetiot gpetiot added this to the 2.0.0 milestone Sep 8, 2020
@NathanReb NathanReb changed the base branch from master to main July 2, 2021 09:46
@gpetiot gpetiot marked this pull request as ready for review July 5, 2021 17:24
@gpetiot gpetiot requested a review from NathanReb July 5, 2021 17:39
Copy link
Collaborator

@Leonidas-from-XIV Leonidas-from-XIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, ready for 2.0.0!

@Leonidas-from-XIV Leonidas-from-XIV merged commit 1e69e26 into realworldocaml:main Sep 24, 2021
@gpetiot gpetiot deleted the remove-mdx-binary branch September 24, 2021 12:25
Leonidas-from-XIV added a commit to Leonidas-from-XIV/opam-repository that referenced this pull request Dec 14, 2021
CHANGES:

#### Added

- Add trailing `;;` to the output of toplevel phrases that were missing it.
  (realworldocaml/mdx#346, @Leonidas-from-XIV)
- Make MDX compatible with OCaml 4.14 (realworldocaml/mdx#356, @NathanReb)

#### Fixed

- Use the same output as the normal toplevel. Mdx used to carry an unsafe patch
  to work around a bug fixed in OCaml 4.06 and that patch would change the
  printed types in some corner cases. (realworldocaml/mdx#322, @emillon)

#### Removed

- Dropped compatibility with older OCaml versions. The minimal supported range
  is 4.08 to 4.13 now (realworldocaml/mdx#345, @Leonidas-from-XIV)
- Do not install deprecated `mdx` binary anymore (realworldocaml/mdx#274, @gpetiot)
- Remove deprecated `rule` command (realworldocaml/mdx#312, @gpetiot)
- Remove support for `require-package` label, use the `mdx` stanza in dune
  instead. This label was only used for the `rule` command and can now be
  safely removed. (realworldocaml/mdx#363, @Leonidas-from-XIV)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants