Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes false positives on explicit_type_interface with type reference assignments #2641

Merged
merged 4 commits into from
Feb 14, 2019

Conversation

Jeehut
Copy link
Collaborator

@Jeehut Jeehut commented Feb 12, 2019

Fixes #2636.

@SwiftLintBot
Copy link

SwiftLintBot commented Feb 12, 2019

12 Messages
📖 Linting Aerial with this PR took 1.82s vs 1.82s on master (0% slower)
📖 Linting Alamofire with this PR took 3.98s vs 3.91s on master (1% slower)
📖 Linting Firefox with this PR took 12.96s vs 12.41s on master (4% slower)
📖 Linting Kickstarter with this PR took 0.2s vs 0.2s on master (0% slower)
📖 Linting Moya with this PR took 1.82s vs 1.86s on master (2% faster)
📖 Linting Nimble with this PR took 1.71s vs 1.71s on master (0% slower)
📖 Linting Quick with this PR took 0.55s vs 0.55s on master (0% slower)
📖 Linting Realm with this PR took 3.29s vs 3.31s on master (0% faster)
📖 Linting SourceKitten with this PR took 1.11s vs 1.12s on master (0% faster)
📖 Linting Sourcery with this PR took 4.1s vs 3.97s on master (3% slower)
📖 Linting Swift with this PR took 26.83s vs 26.85s on master (0% faster)
📖 Linting WordPress with this PR took 20.58s vs 20.74s on master (0% faster)

Generated by 🚫 Danger

@marcelofabri marcelofabri merged commit 0bc7d41 into master Feb 14, 2019
@Jeehut Jeehut deleted the cg-explicit_type_interface-fix branch February 14, 2019 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants