Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive in rule explicit_type_interface with allowRedundancy #2636

Closed
Jeehut opened this issue Feb 12, 2019 · 2 comments
Closed

False positive in rule explicit_type_interface with allowRedundancy #2636

Jeehut opened this issue Feb 12, 2019 · 2 comments
Assignees

Comments

@Jeehut
Copy link
Collaborator

Jeehut commented Feb 12, 2019

For this code

private let l10n = L10n.Communication.self

using this configuration

explicit_type_interface:
  allow_redundancy: true
  excluded:
    - local

there shouldn't be any warnings, but there is.

Rationale: The usage of this rule here is mostly for improving readability, not performance of the compiler. We also try to prevent redundant type annotations, why explicitly writing the type here wouldn't be right. Thus this rules behavior must be changed.

@rocklyve
Copy link

with this example:

static var `default` = Settings()

there is the warning explicit_type_interface, but there shouldn't be any warning.
I think the backticks ` causes this warning.

Can you please fix this?
Thanks :)

@Jeehut
Copy link
Collaborator Author

Jeehut commented Jul 16, 2019

@rocklyve This issue was closed long ago. Please create a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants