Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in notifications #5678

Merged
merged 3 commits into from
May 9, 2019
Merged

Fix bug in notifications #5678

merged 3 commits into from
May 9, 2019

Commits on May 8, 2019

  1. Fix bug in notifications 

    If an exception is raised before setting the self.build and self.version
objects, we ended up with those having the value of `{}` (empty dict).

In send_notification we expect to have these objects initialized.
We should refactor this to only have one point where to catch exceptions
and send the notification from there. Related to readthedocs#5672
    @stsewd
    stsewd committed May 8, 2019
    Configuration menu
    Copy the full SHA
    ace8325 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2019

  1. Prevent unbound variable

    @stsewd
    stsewd committed May 9, 2019
    Configuration menu
    Copy the full SHA
    bff6677 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix-bug-in-notifications

    @stsewd
    stsewd committed May 9, 2019
    Configuration menu
    Copy the full SHA
    a684b32 View commit details
    Browse the repository at this point in the history