Fix bug in notifications #5678
Merged
Fix bug in notifications #5678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an exception is raised before setting the self.build and self.version
objects, we ended up with those having the value of `{}` (empty dict).
In send_notification we expect to have these objects initialized.
We should refactor this to only have one point where to catch exceptions
and send the notification from there. Related to readthedocs#5672
|
Here is where these objects don't get initialized if the api call fails |
|
No changes are needed for the coporate site |
humitos
reviewed
May 9, 2019
|
So, current flow granitize that if we ended up in the I'm keeping the if statement just in case we mutate the object in another part of the code (not likely or I hope so p:). If the object ended up without an id or None we will see it in sentry. Current implementation has the same problem anyway. |
davidfischer
reviewed
May 9, 2019
| except vcs_support_utils.LockTimeout as e: | ||
| self.task.retry(exc=e, throw=False) | ||
| raise VersionLockedError | ||
| except SoftTimeLimitExceeded: | ||
| raise BuildTimeoutError | ||
|
|
||
| # Finalize build and update web servers | ||
| if build_id: | ||
| if self.build.get('id'): |
There was a problem hiding this comment.
I had a slightly different fix for this in #5549.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an exception is raised before setting the self.build and self.version
objects, we ended up with those having the value of
{}(empty dict).In send_notification we expect to have these objects initialized.
We should refactor this to only have one point where to catch exceptions
and send the notification from there. Related to #5672