Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvement: cache version listing on the homepage #4526

Merged
merged 7 commits into from
Aug 15, 2018
Merged

Performance improvement: cache version listing on the homepage #4526

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
236ca5e
Performance improvement: stop listing all versions on the homepage
ericholscher Aug 15, 2018
4158288
Properly check for version
ericholscher Aug 15, 2018
7fd60f4
Handle case with no stable
ericholscher Aug 15, 2018
1da4b77
Cache the version list instead
ericholscher Aug 15, 2018
719befa
Dont depend on list
ericholscher Aug 15, 2018
9b08812
Load cache :)
ericholscher Aug 15, 2018
edd7f76
Better cache name
ericholscher Aug 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions readthedocs/templates/homepage.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
{% load i18n %}
{% load humanize %}
{% load pagination_tags %}
{% load cache %}

{% block extra_metas %}
<meta name="description" content="{% trans "Read the Docs simplifies technical documentation by automating building, versioning, and hosting for you. Build up-to-date documentation for the web, print, and offline use on every version control push automatically." %}">
Expand Down Expand Up @@ -116,6 +117,7 @@ <h3>Multiple versions</h3>
</section>

{% if featured_list %}
{% cache 600 homepage %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The identifier should probably be more specific, ie: homepage_featured_list

<!-- BEGIN projects list -->
<section>
<h3>{% trans "Featured Projects" %}</h3>
Expand All @@ -128,6 +130,7 @@ <h3>{% trans "Featured Projects" %}</h3>
</div>
</section>
<!-- END projects list -->
{% endcache %}
{% endif %}

<!-- Funding and Contributing -->
Expand Down