Performance improvement: cache version listing on the homepage #4526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is similar to #4524, where resolving a ton of URL's for versions is time consuming. This limits that by only listing the stable version, if it exists, for featured projects on our homepage
ericholscher
changed the title
ericholscher
requested review from
davidfischer and
a team
and removed request for
davidfischer
|
Outcome in testing on one of our web servers:
That is 1500ms to 100ms. |
agjohnson
reviewed
Aug 15, 2018
readthedocs/templates/homepage.html
Outdated
| @@ -116,6 +116,7 @@ <h3>Multiple versions</h3> | |||
| </section> | |||
|
|
|||
| {% if featured_list %} | |||
| {% cache 600 homepage %} | |||
There was a problem hiding this comment.
The identifier should probably be more specific, ie: homepage_featured_list
davidfischer
approved these changes
Aug 15, 2018
humitos
approved these changes
Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to #4524,
where resolving a ton of URL's for versions is time consuming.
This caches the features projects list on the homepage.