-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move config module from rtd-build repo #4242
Move config module from rtd-build repo #4242
Conversation
Dependencies problem with |
pytest-describe is incompatible with the current pytest (3.6.1) had to downgrade to 3.2.5
pytest<4,>=3.3.2 | ||
# 3.6.1 and >3.2.5 is incompatible | ||
# with pytest-describe 0.11.0 | ||
pytest==3.2.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pytest-describe
is incompatible with the current pytest (3.6.1
) had to downgrade to 3.2.5
😧. We can port those tests later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make an issue to address this later in the project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened an issue here #4270
Not sure if this PR is big enough, but is ready. I think moving |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I checked this out locally to test the diffs on these files. Looks like minimal changes.
I think you're right that the last piece will be the most changes, when porting over config.py. If you're going to address in a separate PR, we can merge this now.
pytest<4,>=3.3.2 | ||
# 3.6.1 and >3.2.5 is incompatible | ||
# with pytest-describe 0.11.0 | ||
pytest==3.2.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make an issue to address this later in the project.
Still WIP