Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port tests from pytest-describe to normal pytest tests #4270

Closed
stsewd opened this issue Jun 19, 2018 · 4 comments
Closed

Port tests from pytest-describe to normal pytest tests #4270

stsewd opened this issue Jun 19, 2018 · 4 comments
Labels
Improvement Minor improvement to code
Milestone

Comments

@stsewd
Copy link
Member

stsewd commented Jun 19, 2018

The pytest-describe project seems abandoned, isn't compatible with a current version of pytest. We should port this tests. and delete the pytest-describe dependency to update pytest to a more current version.

Raised in https://github.com/rtfd/readthedocs.org/pull/4242/files#r195538134

@stsewd stsewd added the Needed: design decision A core team decision is required label Jun 19, 2018
@mashrikt
Copy link
Contributor

Can we replace describe-blocks with class?
Like: def describe_validate_use_system_site_packages():
to: class ValidateUseSystemSitePackages:

@stsewd
Copy link
Member Author

stsewd commented Jul 25, 2018

Yes, I was thinking the same, this issue is kind of blocked till we end the v2 of the configuration file https://github.com/orgs/rtfd/projects/2 (not sure if you can see the project).

@mashrikt
Copy link
Contributor

I've made a PR for this, since I was working on it.
I understand it has to be merged later. Would still appreciate your review!

@agjohnson agjohnson added this to the Refactoring milestone Aug 3, 2018
@stsewd stsewd added Improvement Minor improvement to code and removed Needed: design decision A core team decision is required labels Oct 25, 2018
@ericholscher
Copy link
Member

Fixed in #4429

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code
Projects
None yet
Development

No branches or pull requests

4 participants