Skip to content
This repository was archived by the owner on Nov 28, 2022. It is now read-only.

fix: issue in node-simple snippets where basic auth wasn't decoded#989

Merged
erunion merged 1 commit intonextfrom
fix/node-simple-basic-auth
Oct 16, 2020
Merged

fix: issue in node-simple snippets where basic auth wasn't decoded#989
erunion merged 1 commit intonextfrom
fix/node-simple-basic-auth

Conversation

@erunion
Copy link
Member

@erunion erunion commented Oct 16, 2020

🧰 What's being changed?

This upgrades the node-simple code snippet generator to fix a couple issues, namely being that Basic auth wasn't being decoded for sdk.auth() calls.

Screen Shot 2020-10-16 at 4 24 48 PM

With the fixes in the library:

Screen Shot 2020-10-16 at 4 22 23 PM

Resolves https://github.com/readmeio/api-explorer/issues/832

🧪 Testing

You can test out basic auth with the auth-types definition.

📖 Release Notes

2.4.0 (2020-10-16)

@erunion erunion added type:bug Something isn't working scope:dependency Pull requests that update a dependency file labels Oct 16, 2020
@erunion erunion merged commit b04e46b into next Oct 16, 2020
@erunion erunion deleted the fix/node-simple-basic-auth branch October 16, 2020 23:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

scope:dependency Pull requests that update a dependency file type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simple mode API snippet auth is being erroneously base64 encoded

1 participant