This repository was archived by the owner on Nov 28, 2022. It is now read-only.
fix: issue in node-simple snippets where basic auth wasn't decoded#989
Merged
fix: issue in node-simple snippets where basic auth wasn't decoded#989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
This upgrades the
node-simplecode snippet generator to fix a couple issues, namely being thatBasicauth wasn't being decoded forsdk.auth()calls.With the fixes in the library:
Resolves https://github.com/readmeio/api-explorer/issues/832
🧪 Testing
You can test out basic auth with the auth-types definition.
📖 Release Notes
2.4.0 (2020-10-16)
.auth()calls (Fix issue where default values wouldn't be saved into the formData until edited #179) (2351b95), closes #179