This repository was archived by the owner on Nov 28, 2022. It is now read-only.
Fix issue where default values wouldn't be saved into the formData until edited#179
Merged
domharrington merged 2 commits intomasterfrom Dec 13, 2018
Merged
Fix issue where default values wouldn't be saved into the formData until edited#179domharrington merged 2 commits intomasterfrom
domharrington merged 2 commits intomasterfrom
Conversation
…til edited You can test this locally here: http://localhost:9966/?selected=swagger-files%2Ftypes.json Search for "default value" and see that it is already in the code sample. This issue luckily got fixed upstream: rjsf-team/react-jsonschema-form#1034 So to bring that in I needed to update my fork of the module. I would love to get off of my fork and get back onto the main release, but there's some outstanding work on my PR which means we can't right now: rjsf-team/react-jsonschema-form#954
Member
Author
|
We should deprecate the x-send-defaults option if it's no longer necessary: https://readme.readme.io/docs/swagger-extensions#section-send-defaults |
domharrington
added a commit
that referenced
this pull request
Dec 12, 2018
On production right now if there's a nested object in a form, it always get
in the code sample even if the form values are not set:
```
--data '{"category":{}}'
```
This PR recursively removes empty objects from the form values so they
do not get set when making the request.
This problem was slightly exacerbated by #179 which auto applied default
values from the form to the samples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can test this locally here: http://localhost:9966/?selected=swagger-files%2Ftypes.json
Search for "default value" and see that it is already in the code sample.
This issue luckily got fixed upstream:
rjsf-team/react-jsonschema-form#1034
So to bring that in I needed to update my fork of the module.
I would love to get off of my fork and get back onto the main release,
but there's some outstanding work on my PR which means we can't right now:
rjsf-team/react-jsonschema-form#954